dee

Code review comment for lp:~mhr3/dee/more-tests

Revision history for this message
Paweł Stołowski (stolowski) wrote :

54 + /* Let's also test dee_model_prev at least once */
55 + g_assert (dee_model_get_first_iter (m) == dee_model_prev (m, iter));

Can you add a couple more checks for _prev? E.g. prev originating from dee_model_last_iter and dee_model_prev (m, dee_model_get_first_iter (m))?

163 + dee_model_append (fix->txn, TRUE, 27, 27, 27,
164 + G_GINT64_CONSTANT (27), G_GUINT64_CONSTANT (27),
165 + 27.0, "TwentySeven");

I think it would be better to use different value for every column.

review: Needs Fixing

« Back to merge proposal