dee

Merge lp:~mhr3/dee/gir-compare-row-func into lp:dee

Proposed by Michal Hruby
Status: Merged
Approved by: Michal Hruby
Approved revision: 357
Merged at revision: 357
Proposed branch: lp:~mhr3/dee/gir-compare-row-func
Merge into: lp:dee
Diff against target: 27 lines (+3/-3)
2 files modified
src/dee-model.h (+2/-2)
vapi/dee-1.0.vapi (+1/-1)
To merge this branch: bzr merge lp:~mhr3/dee/gir-compare-row-func
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+98185@code.launchpad.net

Commit message

Fix DeeCompareRowFunc gir annotation.

Description of the change

Fix DeeCompareRowFunc gir annotation.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

My gut says that this wont fix the case for pygi, but let's get this in.

review: Approve
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Ah, right. I think https://bugzilla.gnome.org/show_bug.cgi?id=667244 explains the pygi situation.

Revision history for this message
Unity Merger (unity-merger) wrote :

No commit message specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/dee-model.h'
2--- src/dee-model.h 2012-02-21 08:54:47 +0000
3+++ src/dee-model.h 2012-03-19 11:24:18 +0000
4@@ -64,8 +64,8 @@
5
6 /**
7 * DeeCompareRowFunc:
8- * @row1: The model being indexed
9- * @row2: The row to extract terms for
10+ * @row1: (array): The model being indexed
11+ * @row2: (array): The row to extract terms for
12 * @user_data: (closure): User data to pass to comparison function
13 *
14 * Compares @row1 and @row2. Mainly used with dee_model_insert_sorted() and
15
16=== modified file 'vapi/dee-1.0.vapi'
17--- vapi/dee-1.0.vapi 2012-02-28 10:56:27 +0000
18+++ vapi/dee-1.0.vapi 2012-03-19 11:24:18 +0000
19@@ -341,7 +341,7 @@
20 [CCode (cheader_filename = "dee.h", instance_pos = 1.9)]
21 public delegate string CollatorFunc (string input);
22 [CCode (cheader_filename = "dee.h", instance_pos = 2.9)]
23- public delegate int CompareRowFunc (GLib.Variant row1, GLib.Variant row2);
24+ public delegate int CompareRowFunc ([CCode (array_length = false)] GLib.Variant[] row1, [CCode (array_length = false)] GLib.Variant[] row2);
25 [CCode (cheader_filename = "dee.h", instance_pos = 2.9)]
26 public delegate void FilterMapFunc (Dee.Model orig_model, Dee.FilterModel filter_model);
27 [CCode (cheader_filename = "dee.h", instance_pos = 3.9)]

Subscribers

People subscribed via source and target branches

to all changes: