Merge lp:~mhr3/dee/fix-1246263 into lp:dee

Proposed by Michal Hruby
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 431
Merged at revision: 431
Proposed branch: lp:~mhr3/dee/fix-1246263
Merge into: lp:dee
Diff against target: 11 lines (+2/-0)
1 file modified
src/dee-server.c (+2/-0)
To merge this branch: bzr merge lp:~mhr3/dee/fix-1246263
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email:

Commit message

Disconnect signal handlers when unreffing GDBusServer.

Description of the change

Disconnect signal handlers when unreffing GDBusServer, not doing so could have caused a critical during tests (as seen in lp:libunity).

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

I ran libunity's test-scope tests around 1000 times and I didn't see any more dee related criticals (without the patch I saw it after about 200 test runs).

I did see one gio-related race, opened a new bug on bgo for that.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

LGTM. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/dee-server.c'
2--- src/dee-server.c 2012-01-26 14:08:54 +0000
3+++ src/dee-server.c 2013-10-30 12:15:43 +0000
4@@ -364,6 +364,8 @@
6 if (priv->server)
7 {
8+ g_signal_handlers_disconnect_by_func (priv->server, on_new_connection, object);
10 /* this should be done automatically on unref, but it doesn't seem so */
11 g_dbus_server_stop (priv->server);


People subscribed via source and target branches

to all changes: