Merge lp:~mhr3/dee/discard-invalid-transactions into lp:dee
Proposed by
Michal Hruby
Status: | Merged |
---|---|
Approved by: | Didier Roche-Tolomelli |
Approved revision: | 360 |
Merged at revision: | 360 |
Proposed branch: | lp:~mhr3/dee/discard-invalid-transactions |
Merge into: | lp:dee |
Diff against target: |
85 lines (+26/-17) 1 file modified
src/dee-shared-model.c (+26/-17) |
To merge this branch: | bzr merge lp:~mhr3/dee/discard-invalid-transactions |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mikkel Kamstrup Erlandsen (community) | Approve | ||
Review via email: mp+99267@code.launchpad.net |
Commit message
Discard invalid transactions
Description of the change
When we receive a commit on a model that is not valid (wrong seqnum etc), we only emit a warning and apply the transaction. This is wrong as it may leave the model in a weird state, the transaction needs to be discarded.
Discard invalid transactions.
To post a comment you must log in.
Code looks correct. Nice to get rid of the FIXMEs :-)
Testing wise it would be quite a lot of work for little gain. These code paths are quite heavily tested already, and getting into all the nooks and crannies of the ways this can fail is a big undertaking. Very worthwhile, but let's not block this branch on it.