Merge lp:~mhall119/ubuntu-community-accomplishments/approved-loco-team into lp:ubuntu-community-accomplishments

[Michael Hall]

Add accomplishment for being a member of an approved loco team

Add accomplishment for being a member of an approved loco team

** NEEDS SUMMARY AND STEPS ADDED **

[lp:~mhall119/ubuntu-community-accomplishments/approved-loco-team]

146. By Michael Hall on 2012-06-01

Merge from trunk

[Rafał Cieślak (rafalcieslak256)]

Thanks for the MP, Michael!
There are two problems I see about this submission:
 * Fields 'summary' and 'steps' are left empty. I doubt this is intentional, as then there is almost no information about the accomplishment, so I guess you simply forgot to fill them in. Could you please fix that?
 * I wonder if we really want separate accomplishments for 'Be a member of a loco team' and 'Be a member of an approved loco team'. There are mainly two cases: a) the user will get them both at once, if his team is already registered, and b) the user will get just one of them, if his team is not registered. In both there is only one element for rewarding him for his activity, that is joining a LoCo. The fact of whether his loco is registered or not is not much an average can do about when he joins the team. This said, the only thing worth rewarding in that matter would be 'Get your LoCo to be approved', but that's a different story. I have requested a review directly from Jono, maybe he can help recognize if such accomplishment makes sense.

review: Needs Information

[Michael Hall (mhall119)]

The 'summary' and 'steps' fields were left empty because Jono was going to fill them in.

This accomplishment is for approved teams, not registered teams. Approved teams are existing teams that have shown a consistent level of activity and commitment to Ubuntu, they must apply for Approved status with the LoCo Council, and once approved they receive some support from Canonical (free CDs for example). More about team approval here: http://loco.ubuntu.com/loco-council/approved

[Rafał Cieślak (rafalcieslak256)]

Right. I am pretty much aware of what approved teams are, but my point
is that one does not choose the LoCo they belong to, so rewarding a
particular user for belonging to an approved team may get unfair.

 * I lives in Poland, and the Polish LoCo is not approved (and there
are no chances it will). That means I will get the "Be a Member of a
LoCo Team" accomplishment, but not "Be a Member of a Approved LoCo
Team"
 * User X lives in UK. It happens that UK LoCo is approved, thus he
means he gets both trophies, "Be a Member of a LoCo Team" and "Be a
Member of a Approved LoCo Team", so he is rewarded twice.
Keeping in mind that accomplishments are meant to reward users for
their activity in the community, I fail to see what user X did what I
have not done (or what he did better then I did), that was worth
rewarding by that second trophy he got (and I did not).

[Jono Bacon (jonobacon)]

I tend to agree with Rafal here, I don't think we need to distinguish between an approved and non-approved team, and we already have a LoCo Team member accom.

review: Disapprove

Unmerged revisions

146. By Michael Hall on 2012-06-01

Merge from trunk

145. By Michael Hall on 2012-06-01

Add LoCo Teams:Membership to the CATEGORIES file

144. By Michael Hall on 2012-06-01

Add sub-category for LoCo Teams:Membership

143. By Michael Hall on 2012-06-01

Add accomplishment for being a member of an approved loco team

=== modified file 'CATEGORIES'
--- CATEGORIES	2012-06-01 20:08:57 +0000
+++ CATEGORIES	2012-06-01 22:12:22 +0000
@@ -15,6 +15,7 @@
     Your Profile
     Code Hosting
 LoCo Teams
+    Membership
     Events
 QA
 Forums

=== added file 'accomplishments/ubuntu-community/en/advocacy/member-approved-loco-team.accomplishment'
--- accomplishments/ubuntu-community/en/advocacy/member-approved-loco-team.accomplishment	1970-01-01 00:00:00 +0000
+++ accomplishments/ubuntu-community/en/advocacy/member-approved-loco-team.accomplishment	2012-06-01 22:12:22 +0000
@@ -0,0 +1,17 @@
+[accomplishment]
+title=Approved LoCo Team Member
+description=You are a member of an Approved Ubuntu LoCo Team
+collection=ubuntu-community
+category=LoCo Teams:Membership
+needs-signing=true
+icon=loco.png
+depends=ubuntu-community/member-loco-team
+needs-information=launchpad-email
+summary = 
+steps: 
+links: http://loco.ubuntu.com/loco-council/approved
+    https://wiki.ubuntu.com/LoCoGettingApproved
+    https://wiki.ubuntu.com/LoCoFAQ
+help = #ubuntu-locoteams on Freenode
+    #ubuntu-community-team on Freenode
+author = Michael Hall <[e-mail]>

=== modified file 'accomplishments/ubuntu-community/en/advocacy/member-loco-team.accomplishment'
--- accomplishments/ubuntu-community/en/advocacy/member-loco-team.accomplishment	2012-05-24 21:28:36 +0000
+++ accomplishments/ubuntu-community/en/advocacy/member-loco-team.accomplishment	2012-06-01 22:12:22 +0000
@@ -2,7 +2,7 @@
 title=LoCo Team Member
 description=You are a member of an Ubuntu LoCo Team
 collection=ubuntu-community
-category=LoCo Teams
+category=LoCo Teams:Membership
 needs-signing=true
 icon=loco.png
 depends=ubuntu-community/registered-on-launchpad

=== added file 'scripts/ubuntu-community/advocacy/member-approved-loco-team.py'
--- scripts/ubuntu-community/advocacy/member-approved-loco-team.py	1970-01-01 00:00:00 +0000
+++ scripts/ubuntu-community/advocacy/member-approved-loco-team.py	2012-06-01 22:12:22 +0000
@@ -0,0 +1,35 @@
+#!/usr/bin/python
+import traceback, sys
+
+from accomplishments.daemon import dbusapi
+from launchpadlib.launchpad import Launchpad
+
+try:
+    api = dbusapi.Accomplishments()
+    f = api.get_extra_information("ubuntu-community", "launchpad-email")
+    if bool(f[0]["launchpad-email"]) == False:
+        sys.exit(2)
+    else:
+        email = f[0]["launchpad-email"]
+    lp = Launchpad.login_anonymously(
+        'ubuntu-community accomplishments', 'production')
+    me = lp.people.getByEmail(email=email)
+    if me == None:
+        sys.exit(1)
+    else:
+        user = me.name
+        final = []
+        for team in me.super_teams:
+            for sup in team.super_teams:
+                if "locoteams-approved" in sup.self_link.rsplit('~', 1)[-1]:
+                    final.append(sup)
+        if len(final) is not 0:
+            sys.exit(0)
+        else:
+            sys.exit(1)
+
+except SystemExit, e:
+    sys.exit(e.code)
+except:
+    traceback.print_exc()
+    sys.exit(2)

=== added file 'tests/ubuntu-community/advocacy/member-approved-loco-team'
--- tests/ubuntu-community/advocacy/member-approved-loco-team	1970-01-01 00:00:00 +0000
+++ tests/ubuntu-community/advocacy/member-approved-loco-team	2012-06-01 22:12:22 +0000
@@ -0,0 +1,5 @@
+[success]
+launchpad-email = [e-mail]
+
+[failure]
+launchpad-email = [e-mail]