Merge lp:~mhall119/ubuntu-calculator-app/reapply-new-styling into lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

Proposed by Michael Hall
Status: Merged
Approved by: Michael Hall
Approved revision: 94
Merged at revision: 94
Proposed branch: lp:~mhall119/ubuntu-calculator-app/reapply-new-styling
Merge into: lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk
Diff against target: 48 lines (+11/-2)
2 files modified
Simple/CalcLabel.qml (+6/-1)
Simple/Screen.qml (+5/-1)
To merge this branch: bzr merge lp:~mhall119/ubuntu-calculator-app/reapply-new-styling
Reviewer Review Type Date Requested Status
Florian Boucault (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Calculator Developers Pending
Review via email: mp+173261@code.launchpad.net

Commit message

Reapplying revision 90 to use the new styling method

Description of the change

Reapplying revision 90 to use the new styling method

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Florian Boucault (fboucault) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Simple/CalcLabel.qml'
2--- Simple/CalcLabel.qml 2013-07-03 16:27:23 +0000
3+++ Simple/CalcLabel.qml 2013-07-05 18:01:30 +0000
4@@ -18,6 +18,7 @@
5
6 import QtQuick 2.0
7 import Ubuntu.Components 0.1
8+import Ubuntu.Components.Themes.Ambiance 0.1
9
10 Item {
11 id: root
12@@ -69,7 +70,11 @@
13 id: numberName
14 width: parent.width
15 anchors.verticalCenter: parent.verticalCenter
16- ItemStyle.delegate: Item{} // removes ubuntu shape
17+ // removes ubuntu shape
18+ style: TextFieldStyle {
19+ background: Item {}
20+ }
21+
22 readOnly: labelReadOnly
23 text: labelText
24 color: "#FEFEFE"
25
26=== modified file 'Simple/Screen.qml'
27--- Simple/Screen.qml 2013-07-03 16:27:23 +0000
28+++ Simple/Screen.qml 2013-07-05 18:01:30 +0000
29@@ -18,6 +18,7 @@
30
31 import QtQuick 2.0
32 import Ubuntu.Components 0.1
33+import Ubuntu.Components.Themes.Ambiance 0.1
34 import Ubuntu.Components.ListItems 0.1
35
36 //TODO: reuse a number clicking on it
37@@ -128,7 +129,10 @@
38
39 TextField{
40 width: parent.width
41- ItemStyle.delegate: Item{} // removes ubuntu shape
42+ // removes ubuntu shape
43+ style: TextFieldStyle {
44+ background: Item {}
45+ }
46 text: mainLabel
47 hasClearButton: false
48 color: "#FEFEFE"

Subscribers

People subscribed via source and target branches