Merge lp:~mhall119/summit/fixes-814375 into lp:~summit-hackers/summit/1.x
Proposed by
Michael Hall
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Nigel Babu | ||||
Approved revision: | 140 | ||||
Merged at revision: | 140 | ||||
Proposed branch: | lp:~mhall119/summit/fixes-814375 | ||||
Merge into: | lp:~summit-hackers/summit/1.x | ||||
Diff against target: |
136 lines (+53/-14) 5 files modified
summit/schedule/models/meetingmodel.py (+4/-3) summit/schedule/render.py (+1/-1) summit/schedule/tests.py (+45/-7) summit/schedule/views.py (+2/-2) summit/urls.py (+1/-1) |
||||
To merge this branch: | bzr merge lp:~mhall119/summit/fixes-814375 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nigel Babu (community) | Approve | ||
Review via email: mp+68764@code.launchpad.net |
Commit message
Adds the meeting id to the meeting_page_url, and uses only that as the lookup parameter
Description of the change
Overview
========
Meeting names are neither required nor unique, but they were being used as identifiers in the meeting_page_url, throwing errors whenever there wasn't a unique match.
Details
=======
This code adds the meeting id as a part of the URL, and only uses that to perform lookups to find the appropriate meeting. The meeting name is still present in the URL, to make it reader friendly, but it is ignored by the system. If a meeting does not have a name, a single hyphen is used in it's place.
To post a comment you must log in.
Tests pass. Looks good. Approved!