Merge lp:~mhall119/loco-team-portal/globaljam-urls-change into lp:loco-team-portal

Proposed by Michael Hall
Status: Merged
Approved by: Adnane Belmadiaf
Approved revision: 522
Merged at revision: 522
Proposed branch: lp:~mhall119/loco-team-portal/globaljam-urls-change
Merge into: lp:loco-team-portal
Diff against target: 37 lines (+9/-2)
2 files modified
loco_directory/events/urls.py (+2/-1)
loco_directory/events/views.py (+7/-1)
To merge this branch: bzr merge lp:~mhall119/loco-team-portal/globaljam-urls-change
Reviewer Review Type Date Requested Status
Adnane Belmadiaf Approve
Review via email: mp+93228@code.launchpad.net

Commit message

Move dashboard page to /events/globaljam/dashboard/, make /events/globaljam/ an alias to the latest global jam event details page.

Description of the change

Jono has requested this change to the global jam URLs

To post a comment you must log in.
Revision history for this message
Adnane Belmadiaf (daker) wrote :

Approve! it would be good if we can create bug report for features/requests like this so we can track what we are doing.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/events/urls.py'
2--- loco_directory/events/urls.py 2012-02-09 02:06:11 +0000
3+++ loco_directory/events/urls.py 2012-02-15 15:59:25 +0000
4@@ -6,7 +6,8 @@
5 url(r'^history/$', 'events.views.event_history_list', name='event-history-list'),
6
7 #special events
8- url(r'^globaljam/', 'events.views.global_jam', name='global-jam'),
9+ url(r'^globaljam/$', 'events.views.global_jam', name='global-jam-dashboard'),
10+ url(r'^globaljam/dashboard/$', 'events.views.global_jam_dashboard', name='global-jam'),
11
12 #global events
13 url(r'^global/ical/$', 'events.views.global_event_list_ical', name='global-event-list-ical'),
14
15=== modified file 'loco_directory/events/views.py'
16--- loco_directory/events/views.py 2012-02-13 22:46:37 +0000
17+++ loco_directory/events/views.py 2012-02-15 15:59:25 +0000
18@@ -519,12 +519,18 @@
19
20 return HttpResponse(json)
21
22-
23 def global_jam(request):
24 try:
25 global_event_object = GlobalEvent.objects.filter(name='Ubuntu Global Jam').order_by('-date_begin')[0]
26 except IndexError:
27 raise Http404
28+ return global_event_detail(request, global_event_object.id)
29+
30+def global_jam_dashboard(request):
31+ try:
32+ global_event_object = GlobalEvent.objects.filter(name='Ubuntu Global Jam').order_by('-date_begin')[0]
33+ except IndexError:
34+ raise Http404
35
36 context = {
37 'global_event_object': global_event_object,

Subscribers

People subscribed via source and target branches