Merge lp:~mhall119/loco-team-portal/fixes-589290 into lp:loco-team-portal

Proposed by Michael Hall
Status: Merged
Merged at revision: 146
Proposed branch: lp:~mhall119/loco-team-portal/fixes-589290
Merge into: lp:loco-team-portal
Diff against target: 9 lines (+1/-0)
1 file modified
loco_directory/templates/events/global_event_detail_attending_teamevents.inc.html (+1/-0)
To merge this branch: bzr merge lp:~mhall119/loco-team-portal/fixes-589290
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Review via email: mp+26728@code.launchpad.net

Description of the change

Because the link was in a part of the DOM where CSS floating was being used, and before the floating was cleared, the link was also set to float within the list of team events. Adding an element to clear floating within the include file that produces the floating list will ensure that this doesn't happen.

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Good catch.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/templates/events/global_event_detail_attending_teamevents.inc.html'
2--- loco_directory/templates/events/global_event_detail_attending_teamevents.inc.html 2010-05-31 13:07:10 +0000
3+++ loco_directory/templates/events/global_event_detail_attending_teamevents.inc.html 2010-06-03 17:39:27 +0000
4@@ -5,4 +5,5 @@
5 <li class="{% cycle 'col_left' 'col_right' %}"><a title="{% trans "More Information about Team Event" %}" href="{{ team_event.get_absolute_url }}">{{ team_event.name }}</a></li>
6 {% endfor %}
7 </ul>
8+<br class="clear" />
9 {% endif %}

Subscribers

People subscribed via source and target branches