Merge lp:~mhall119/loco-team-portal/bug-508471 into lp:loco-team-portal

[Michael Hall]

[Michael Hall (mhall119)]

The Attendee stuff was checking if the user had registered for an event, but it was failing if the user was AnonymousUser (aka, not logged in). This adds a check to user.is_authenticated(), and will return False on the team_event.is_attending(user) call if the user is not logged in.

[Thomas Bechtold (toabctl)]

Is it possible to use @login_required decorator for the method?

[Michael Hall (mhall119)]

Not in this case, because login_require will simply return an HttpResponseRedirect instead of calling the method, it's really only useful decorating views. I this case, I just want TeamEvent.is_attending(user) to return False if the user isn't logged in, not redirect them to the login page.

[Thomas Bechtold (toabctl)]

i'm not sure why the method is_attending() should be in the TeamEvent manager. I changed some code and uploaded another branch to lp:~thomasbechtold/loco-directory/fix-508471 . I'm not sure if this is more easy. Please check this.

[lp:~mhall119/loco-team-portal/bug-508471]

44. By Michael Hall on 2010-01-19

Added extra validation to make sure an event's end date does not come before it's begin date

[Thomas Bechtold (toabctl)]

super!

review: Approve

=== modified file 'loco_directory/events/models.py'
--- loco_directory/events/models.py	2010-01-11 12:41:30 +0000
+++ loco_directory/events/models.py	2010-01-16 17:57:11 +0000
@@ -115,7 +115,10 @@
         return ('team-event-detail', [str(self.id)])
 
     def is_attending(self, user):
-        return self.attendee_set.filter(attendee=user).count() > 0
+        if user.is_authenticated():
+            return self.attendee_set.filter(attendee=user).count() > 0
+        else:
+            return False
 
     #add manager
     objects = TeamEventManager()