Merge lp:~mhall119/loco-team-portal/fixes-805280 into lp:loco-team-portal
Proposed by
Michael Hall
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Chris Johnston | ||||
Approved revision: | 453 | ||||
Merged at revision: | 457 | ||||
Proposed branch: | lp:~mhall119/loco-team-portal/fixes-805280 | ||||
Merge into: | lp:loco-team-portal | ||||
Diff against target: |
136 lines (+67/-18) 5 files modified
loco_directory/teams/models.py (+7/-0) loco_directory/templates/venues/venue_detail.html (+5/-1) loco_directory/templates/venues/venue_list.html (+1/-1) loco_directory/venues/models.py (+5/-1) loco_directory/venues/tests.py (+49/-15) |
||||
To merge this branch: | bzr merge lp:~mhall119/loco-team-portal/fixes-805280 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chris Johnston | Approve | ||
Review via email: mp+66736@code.launchpad.net |
Commit message
Fix various errors with using country name as part of the venue URL
Description of the change
Overview
========
Reverse lookup was failing on a Korean venue
Details
=======
Reverse lookups were failing because the Country object of Korea has the name "Korea, Republic of" and the comma was causing the error. I introduce a "slug" property to the Country model that will give a safer version of the country name, stripping commas and replacing spaces with underscores.
To post a comment you must log in.
Needs test cases.