UD Theme

Merge lp:~mh0/ubuntu-drupal-theme/6.x-2010 into lp:ubuntu-drupal-theme

Proposed by Micheal Harker on 2010-11-30

Status:	Needs review
Proposed branch:	lp:~mh0/ubuntu-drupal-theme/6.x-2010
Merge into:	lp:ubuntu-drupal-theme
Diff against target:	38 lines (+3/-4) 1 file modified styles/base.css (+3/-4)
To merge this branch:	bzr merge lp:~mh0/ubuntu-drupal-theme/6.x-2010
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Michael Lustfield (community)		2010-11-30	Needs Fixing on 2010-11-30
Review via email: mp+42286@code.launchpad.net

Revision history for this message

Michael Lustfield (michaellustfield) wrote on 2010-11-30:

This merge would involve applying a static minimum width to an element that as a configurable minimum width available from the theme settings.

A min-width should not be used to fix this and should instead be used to decide where horizontal scrolling starts.

In addition, the min-width should not be decided on by the designer but rather by the person using the theme.

review: Needs Fixing

76. By Micheal Harker <michealh@michealh-laptop> on 2010-11-30: Fixed header using margin: -9px auto 0;
77. By Micheal Harker <michealh@michealh-laptop> on 2010-11-30: Fixed issues
78. By Micheal Harker <michealh@michealh-laptop> on 2010-11-30: Fixed a silly mistake
79. By Micheal Harker <michealh@michealh-laptop> on 2010-11-30: Trying something else
80. By Micheal Harker <michealh@michealh-laptop> on 2010-11-30: Fixed broken header

80. By Micheal Harker <michealh@michealh-laptop> on 2010-11-30: Fixed broken header
79. By Micheal Harker <michealh@michealh-laptop> on 2010-11-30: Trying something else
78. By Micheal Harker <michealh@michealh-laptop> on 2010-11-30: Fixed a silly mistake
77. By Micheal Harker <michealh@michealh-laptop> on 2010-11-30: Fixed issues
76. By Micheal Harker <michealh@michealh-laptop> on 2010-11-30: Fixed header using margin: -9px auto 0;
75. By Micheal Harker <michealh@michealh-laptop> on 2010-11-30: For my first merge proposal into lp:ubuntu-drupal-theme

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

1	=== modified file 'styles/base.css'
2	--- styles/base.css 2010-09-10 02:43:22 +0000
3	+++ styles/base.css 2010-11-30 21:59:09 +0000
4	@@ -39,10 +39,10 @@
5
6	#header {
7	height: 70px;
8	- margin: 0px;
9	padding: 0 5px;
10	position: relative;
11	font-size: 14px;
12	+ margin: -9px auto 0;
13	}
14
15	#header li {
16	@@ -184,13 +184,11 @@
17
18	#content {
19	line-height: 1.4em;
20	- overflow: hidden;
21	}
22
23	#content .container {
24	- margin-top: -9px;
25	padding: 20px 0;
26	- overflow: hidden;
27	+ margin: -9px auto 0;
28	}
29
30	#page-content {
31	@@ -361,6 +359,7 @@
32	font-size: 11px;
33	width: 100%;
34	display: table;
35	+margin: -9px auto 0;
36	}
37
38	#footer .block {