Merge lp:~mgorven/ibid/timezone-335551 into lp:~ibid-core/ibid/old-trunk-1.6

[Michael Gorven]

[Stefano Rivera (stefanor)]

Query: time in gmt
Response: I don't know about the gmt timezone

<place> implies that it'll look up countries, but nothing seems to work:

Response: I don't know about the london timezone
Query: time in united kingdom
Response: *blink*
Query: time in great britain
Response: Sorry...
Query: time in uk
Response: I don't know about the uk timezone
Query: time in gb
Response: I don't know about the gb timezone

review: Needs Fixing

[Stefano Rivera (stefanor)]

r'^time\s+in\s+(\S+)$'

It should also match "what is the..."

[Michael Gorven (mgorven)]

On Thursday 31 December 2009 19:54:47 Stefano Rivera wrote:
> It should also match "what is the..."
r825

[Michael Gorven (mgorven)]

Look what you made me do Stefano!

[Stefano Rivera (stefanor)]

any reason why you use different time formats to the rest of the bot?
Look at ibid.utils.format_date

Still some time zone issues:

Query: time in utc
Response: I don't know about the utc timezone
Query: time in UTC
Response: 2010/01/01 12:24:23 SAST is 2010/01/01 10:24:23 UTC
Query: time in uct
Response: I don't know about the uct timezone
Query: time in UCT
Response: 2010/01/01 12:24:48 SAST is 2010/01/01 10:24:48 UCT
Query: time in zulu
Response: I don't know about the zulu timezone
Query: time in Zulu
Response: 2010/01/01 12:24:52 SAST is 2010/01/01 10:24:52 UTC

Otherwise a lot better :)

review: Needs Fixing

[Michael Gorven (mgorven)]

Fixed Stefano's issues, and allow source timezones to contain spaces.

[Stefano Rivera (stefanor)]

gah, I just tried to invoke it with:

Query: what time is it in paris?
Response: Excuse me?

[Michael Gorven (mgorven)]

> gah, I just tried to invoke it with:
>
> Query: what time is it in paris?
> Response: Excuse me?

r831

[Stefano Rivera (stefanor)]

I think we're there

review: Needs Resubmitting

[Stefano Rivera (stefanor)]

gaah, hwtf did that become resumbit?

review: Approve

[Michael Gorven (mgorven)]

To make Jonathan and Stefano happy :-P

[Stefano Rivera (stefanor)]

review: Approve

[Jonathan Hitchcock (vhata)]

Could we have slightly friendlier responses?

[Jonathan Hitchcock (vhata)]

Maybe just an "It's" at the front of the time?

review: Approve

[lp:~mgorven/ibid/timezone-335551]

839. By Michael Gorven on 2010-01-02

Modify response.