Ibid

Merge lp:~mgorven/ibid/setuptools-335124 into lp:~ibid-core/ibid/old-trunk-pack-0.92

  1. setuptools-335124
  2. Merge into old-trunk-pack-0.92
Proposed by Michael Gorven
Status: Merged
Approved by: Jonathan Hitchcock
Approved revision: 710
Merged at revision: not available
Proposed branch: lp:~mgorven/ibid/setuptools-335124
Merge into: lp:~ibid-core/ibid/old-trunk-pack-0.92
Diff against target: None lines
To merge this branch: bzr merge lp:~mgorven/ibid/setuptools-335124
Reviewer Review Type Date Requested Status
Jonathan Hitchcock Approve
Stefano Rivera Approve
Review via email: mp+8700@code.launchpad.net

This proposal supersedes a proposal from 2009-07-13.

To post a comment you must log in.
Revision history for this message
Michael Gorven (mgorven) wrote : Posted in a previous version of this proposal

Install documentation as well.

Revision history for this message
Stefano Rivera (stefanor) wrote : Posted in a previous version of this proposal

Looks fine to me, but what do I know about setuptools?

review: Approve
Revision history for this message
Michael Gorven (mgorven) wrote : Posted in a previous version of this proposal

On Monday 13 July 2009 17:53:38 Stefano Rivera wrote:
> Looks fine to me, but what do I know about setuptools?

What does anyone know about setuptools?! ;-)

Revision history for this message
Jonathan Hitchcock (vhata) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Stefano Rivera (stefanor) wrote : Posted in a previous version of this proposal

Will this cope with the "data" directory I've just added?

review: Needs Information
Revision history for this message
Stefano Rivera (stefanor) :
review: Approve
Revision history for this message
Jonathan Hitchcock (vhata) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MANIFEST.in'
2--- MANIFEST.in 2009-07-08 18:03:40 +0000
3+++ MANIFEST.in 2009-07-13 17:08:34 +0000
4@@ -3,6 +3,10 @@
5 recursive-include tracibid *.py
6 recursive-include contrib *
7 recursive-include lib *
8+recursive-include data *
9 include factpacks/*.json
10 include ibid/*.ini
11 include twisted/plugins/ibid_plugin.py
12+include INSTALL
13+include COPYING
14+include README
15
16=== modified file 'setup.py'
17--- setup.py 2009-07-12 15:31:07 +0000
18+++ setup.py 2009-07-13 17:08:34 +0000
19@@ -41,7 +41,7 @@
20 'http://ibid.omnia.za.net/eggs/',
21 'http://wokkel.ik.nu/downloads',
22 ],
23- packages=['ibid', 'tracibid', 'lib', 'twisted', 'contrib', 'factpacks'],
24+ packages=['ibid', 'tracibid', 'lib', 'twisted', 'data', 'contrib', 'factpacks'],
25 entry_points={
26 'trac.plugins': ['tracibid = tracibid.notifier'],
27 },

Subscribers

People subscribed via source and target branches