Merge lp:~mgorven/ibid/setup-permissions-339470 into lp:~ibid-core/ibid/old-trunk-pack-0.92

Proposed by Michael Gorven on 2009-04-17
Status: Merged
Approved by: Jonathan Hitchcock on 2009-04-20
Approved revision: 595
Merged at revision: 598
Proposed branch: lp:~mgorven/ibid/setup-permissions-339470
Merge into: lp:~ibid-core/ibid/old-trunk-pack-0.92
Diff against target: None lines
To merge this branch: bzr merge lp:~mgorven/ibid/setup-permissions-339470
Reviewer Review Type Date Requested Status
Jonathan Hitchcock Approve on 2009-04-20
Stefano Rivera 2009-04-17 Approve on 2009-04-18
Review via email: mp+5675@code.launchpad.net
To post a comment you must log in.
Michael Gorven (mgorven) wrote :

Adds eval permission to the default set granted to the bot owner. I haven't
added permissions which are granted to everyone by default (factoid, karma,
sendmemo, recvmemo, feeds). Should these go in?

Stefano Rivera (stefanor) wrote :

> Should these go in?

I can see arguments both ways. There's less maintenance hassle if we don't.

Stefano Rivera (stefanor) wrote :

Well, I approve it either way.

review: Approve
Jonathan Hitchcock (vhata) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/ibid-setup'
2--- scripts/ibid-setup 2009-04-14 10:17:42 +0000
3+++ scripts/ibid-setup 2009-04-17 23:12:45 +0000
4@@ -91,7 +91,7 @@
5 u'accounts', u'sources', u'plugins',
6 u'core', u'admin', u'config',
7 u'saydo', u'factoid', u'factoidadmin',
8- u'karma', u'karmaadmin'):
9+ u'karma', u'karmaadmin', u'eval'):
10 perm = Permission(permission, u'auth')
11 account.permissions.append(perm)
12

Subscribers

People subscribed via source and target branches