Merge lp:~mgorven/ibid/http-features-fix into lp:~ibid-core/ibid/old-release-0.1-1.6

Proposed by Michael Gorven
Status: Merged
Approved by: Stefano Rivera
Approved revision: 924
Merged at revision: 928
Proposed branch: lp:~mgorven/ibid/http-features-fix
Merge into: lp:~ibid-core/ibid/old-release-0.1-1.6
Diff against target: 21 lines (+2/-2)
1 file modified
ibid/plugins/__init__.py (+2/-2)
To merge this branch: bzr merge lp:~mgorven/ibid/http-features-fix
Reviewer Review Type Date Requested Status
Max Rabkin Approve
Jonathan Hitchcock Approve
Stefano Rivera Approve
Review via email: mp+21945@code.launchpad.net

Commit message

Update HTTP source for multiple features per processor.

To post a comment you must log in.
Revision history for this message
Stefano Rivera (stefanor) wrote :

I'm ok with this as a 0.1 fix, but it's not applicable to trunk.

review: Approve
Revision history for this message
Stefano Rivera (stefanor) wrote :

Changing my mind on that. It's ok for trunk, if we document that the first feature is the primary one. We also need to rename feature -> features everywhere

Revision history for this message
Jonathan Hitchcock (vhata) :
review: Approve
Revision history for this message
Max Rabkin (max-rabkin) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ibid/plugins/__init__.py'
2--- ibid/plugins/__init__.py 2010-03-02 19:01:47 +0000
3+++ ibid/plugins/__init__.py 2010-03-23 15:30:38 +0000
4@@ -259,7 +259,7 @@
5 isLeaf = True
6
7 def __init__(self):
8- ibid.rpc[self.feature] = self
9+ ibid.rpc[self.feature[0]] = self
10 self.form = templates.get_template('plugin_form.html')
11 self.list = templates.get_template('plugin_functions.html')
12
13@@ -306,7 +306,7 @@
14 if name.startswith('remote_'):
15 functions.append(name.replace('remote_', '', 1))
16
17- return self.list.render(object=self.feature, functions=functions) \
18+ return self.list.render(object=self.feature[0], functions=functions) \
19 .encode('utf-8')
20
21 args, varargs, varkw, defaults = getargspec(function)

Subscribers

People subscribed via source and target branches