GNU Mailman

Merge lp:~mgill25/mailman/mailman into lp:mailman

  1. mailman
  2. Merge into 3.0
Proposed by Manish Gill
Status: Merged
Approved by: Barry Warsaw
Approved revision: 7211
Merge reported by: Barry Warsaw
Merged at revision: not available
Proposed branch: lp:~mgill25/mailman/mailman
Merge into: lp:mailman
Diff against target: 12 lines (+1/-1)
1 file modified
src/mailman/commands/cli_lists.py (+1/-1)
To merge this branch: bzr merge lp:~mgill25/mailman/mailman
Reviewer Review Type Date Requested Status
Barry Warsaw Approve
Review via email: mp+157920@code.launchpad.net

Description of the change

Fix for #1166911

To post a comment you must log in.
Revision history for this message
Bhavesh Goyal (bhavesh-goyal093) wrote :

The Bug was a small typo in cli_lists file. The correct attribute name was 'domain'(corrected in proposed branch) instead of 'domains'(as in original version)

This correction in typo solves the bug and the bug may be marked as closed.

Revision history for this message
Barry Warsaw (barry) wrote :

Thanks for the fix! Please be sure to add a test next time. See src/mailman/commands/tests/test_lists.py. Also, with this patch, src/mailman/commands/docs/lists.rst fails because it was using 'domains' on the fake arguments. Be sure to run the full test suite too.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/mailman/commands/cli_lists.py'
2--- src/mailman/commands/cli_lists.py 2013-01-01 14:05:42 +0000
3+++ src/mailman/commands/cli_lists.py 2013-04-09 17:17:32 +0000
4@@ -90,7 +90,7 @@
5 mlist = list_manager.get(fqdn_name)
6 if args.advertised and not mlist.advertised:
7 continue
8- domains = getattr(args, 'domains', None)
9+ domains = getattr(args, 'domain', None)
10 if domains and mlist.mail_host not in domains:
11 continue
12 mailing_lists.append(mlist)