Merge lp:~mfrey/powerd/filter-proximity into lp:powerd

[Michael Frey]

Filter out first proximity event as it sometimes contains the incorrect sensor state.

Filter out first proximity event as it sometimes contains the incorrect sensor state.
Fixes bugs #1378012 and #1378043

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:143
http://jenkins.qa.ubuntu.com/job/powerd-ci/164/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/16
        deb: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/16/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/powerd-ci/164/rebuild

review: Approve (continuous-integration)

[Ricardo Salveti (rsalveti)]

review: Needs Fixing

[lp:~mfrey/powerd/filter-proximity]

144. By Michael Frey on 2014-10-07

Change warn to debug output

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:144
http://jenkins.qa.ubuntu.com/job/powerd-ci/166/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/18
        deb: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/18/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/powerd-ci/166/rebuild

review: Approve (continuous-integration)

[Ricardo Salveti (rsalveti)]

While testing I noticed that if I start a call with something covering up the proximity sensor, the screen will never be off, which might be a side effect of this change.

I wonder if it might be better to work instead fixing the sensor for this hardware specifically, for it to always give a valid value when doing the first read. I know bug #1378043 is actually a side effect of doing the screen handling on powerd and not as part of the phone stack (if the screen gets off before the call starts, the phone will lock itself).

review: Needs Fixing

[lp:~mfrey/powerd/filter-proximity]

145. By Michael Frey on 2014-10-08

Delay enable of prox sensor rather than filter

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:145
http://jenkins.qa.ubuntu.com/job/powerd-ci/167/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/19
        deb: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/19/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/powerd-ci/167/rebuild

review: Approve (continuous-integration)

[lp:~mfrey/powerd/filter-proximity]

146. By Michael Frey on 2014-10-08

reduce the delay to .5 sec

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:146
http://jenkins.qa.ubuntu.com/job/powerd-ci/168/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/20
        deb: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/20/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/powerd-ci/168/rebuild

review: Approve (continuous-integration)

[lp:~mfrey/powerd/filter-proximity]

147. By Michael Frey on 2014-10-09

bump delay

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:147
http://jenkins.qa.ubuntu.com/job/powerd-ci/169/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/21
        deb: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/21/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/powerd-ci/169/rebuild

review: Approve (continuous-integration)

Unmerged revisions

147. By Michael Frey on 2014-10-09

bump delay

146. By Michael Frey on 2014-10-08

reduce the delay to .5 sec

145. By Michael Frey on 2014-10-08

Delay enable of prox sensor rather than filter

144. By Michael Frey on 2014-10-07

Change warn to debug output

143. By Michael Frey <michael@michael-MacBookAir> on 2014-10-06

Filter out first proximity event to aviod incorrect reading

=== modified file 'src/powerd-sensors.cpp'
--- src/powerd-sensors.cpp	2014-06-13 15:56:20 +0000
+++ src/powerd-sensors.cpp	2014-10-09 13:51:53 +0000
@@ -48,6 +48,12 @@
 
 void powerd_sensors_proximity_enable(void)
 {
+    /*
+     *Delay the start of the prox sensor
+     *as starting too fast causes unwanted 
+     *behavior like locking the screen while starting a call
+     */
+    usleep(850000);
     ua_sensors_proximity_enable(prox_sensor);
 }