selenium-simple-test

Merge lp:~mfoord/selenium-simple-test/fix-loop into lp:selenium-simple-test

  1. fix-loop
  2. Merge into trunk
Proposed by Michael Foord
Status: Merged
Approved by: Corey Goldberg
Approved revision: 437
Merged at revision: 437
Proposed branch: lp:~mfoord/selenium-simple-test/fix-loop
Merge into: lp:selenium-simple-test
Diff against target: 12 lines (+1/-1)
1 file modified
src/sst/cases.py (+1/-1)
To merge this branch: bzr merge lp:~mfoord/selenium-simple-test/fix-loop
Reviewer Review Type Date Requested Status
Corey Goldberg (community) Approve
Review via email: mp+194400@code.launchpad.net

Commit message

Fix a loop to iterate the correct number of times.

To post a comment you must log in.
Revision history for this message
Corey Goldberg (coreygoldberg) wrote :

nice catch

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/sst/cases.py'
2--- src/sst/cases.py 2013-09-15 16:22:43 +0000
3+++ src/sst/cases.py 2013-11-07 18:36:33 +0000
4@@ -97,7 +97,7 @@
5
6 def start_browser(self):
7 max_attempts = 5
8- for nb_attempts in range(1, max_attempts):
9+ for nb_attempts in range(1, max_attempts + 1):
10 try:
11 logger.debug('Starting browser (attempt: %d)' % nb_attempts)
12 self._start_browser()

Subscribers

People subscribed via source and target branches