Merge lp:~mfoord/juju-core/write-majority into lp:~go-bot/juju-core/trunk

[Michael Foord]

[William Reade (fwereade)]

Don't we also want `J: true` in there?

[John A Meinel (jameinel)]

AIUI we want both, yes.

Is there a way to test that we are setting this up at the appropriate time? (A simple test that said "are we connected to state with write majority set" )

[Andrew Wilkins (axwalk)]

Marking WIP pending further discussion.

[Andrew Wilkins (axwalk)]

Also, if we're already setting write majority then I think waiting for the jounral group commit is a win for little additional cost.

[Andrew Wilkins (axwalk)]

Although it really depends on how often we write. See: http://comments.gmane.org/gmane.comp.db.mongodb.user/52268

[Michael Foord (mfoord)]

Moved to github (although still WIP): https://github.com/voidspace/juju/compare/write-majority

Unmerged revisions

2747. By Michael Foord on 2014-05-23

Initial merge

2746. By Michael Foord on 2014-05-23

Merge

=== modified file 'state/open.go'
--- state/open.go	2014-05-19 20:36:21 +0000
+++ state/open.go	2014-05-23 15:44:04 +0000
@@ -93,6 +93,10 @@
 	}
 	logger.Debugf("connection established")
 
+	// set mongo to write-majority (writes only returned after replicated to a
+	// majority of replica-set members)
+	session.SetSafe(&mgo.Safe{WMode: "majority"})
+
 	st, err := newState(session, info, policy)
 	if err != nil {
 		session.Close()