juju-core

Merge lp:~mfoord/juju-core/refresh-session into lp:~go-bot/juju-core/trunk

  1. refresh-session
  2. Merge into trunk
Proposed by Michael Foord
Status: Needs review
Proposed branch: lp:~mfoord/juju-core/refresh-session
Merge into: lp:~go-bot/juju-core/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
replicaset/replicaset.go (+1/-0)
To merge this branch: bzr merge lp:~mfoord/juju-core/refresh-session
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+221857@code.launchpad.net

Commit message

replicaset/Initiate: refresh the session

We're seeing in very rare circumstances
fetching replica set status fail due to
a closed socket. Refreshing the session
should fix that.

Description of the change

replicaset/Initiate: refresh the session

We're seeing in very rare circumstances
fetching replica set status fail due to
a closed socket. Refreshing the session
should fix that.

https://codereview.appspot.com/102980043/

To post a comment you must log in.
Revision history for this message
Michael Foord (mfoord) wrote :

Reviewers: mp+221857_code.launchpad.net,

Message:
Please take a look.

Description:
replicaset/Initiate: refresh the session

We're seeing in very rare circumstances
fetching replica set status fail due to
a closed socket. Refreshing the session
should fix that.

https://code.launchpad.net/~mfoord/juju-core/refresh-session/+merge/221857

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/102980043/

Affected files (+3, -0 lines):
   A [revision details]
   M replicaset/replicaset.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-20140602214617-ol3o05x718vhc0aj
+New revision: <email address hidden>

Index: replicaset/replicaset.go
=== modified file 'replicaset/replicaset.go'
--- replicaset/replicaset.go 2014-06-02 16:04:06 +0000
+++ replicaset/replicaset.go 2014-06-03 10:41:31 +0000
@@ -71,6 +71,7 @@
   }

   for i := 0; i < maxInitiateStatusAttempts; i++ {
+ monotonicSession.Refresh()
    status, err := getCurrentStatus(monotonicSession)
    if err != nil {
     logger.Warningf("Initiate: fetching replicaset status failed: %v", err)

Reply
Revision history for this message
Nate Finch (natefinch) wrote :

LGTM

https://codereview.appspot.com/102980043/

Reply

Unmerged revisions

2763. By Michael Foord

Refresh session

2762. By Michael Foord

Merge

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'replicaset/replicaset.go'
2--- replicaset/replicaset.go 2014-06-02 16:04:06 +0000
3+++ replicaset/replicaset.go 2014-06-03 10:53:22 +0000
4@@ -71,6 +71,7 @@
5 }
6
7 for i := 0; i < maxInitiateStatusAttempts; i++ {
8+ monotonicSession.Refresh()
9 status, err := getCurrentStatus(monotonicSession)
10 if err != nil {
11 logger.Warningf("Initiate: fetching replicaset status failed: %v", err)

Subscribers

People subscribed via source and target branches

to status/vote changes: