juju-core

Merge lp:~mfoord/juju-core/local-mongo into lp:~go-bot/juju-core/trunk

  1. local-mongo
  2. Merge into trunk
Proposed by Michael Foord
Status: Rejected
Rejected by: Andrew Wilkins
Proposed branch: lp:~mfoord/juju-core/local-mongo
Merge into: lp:~go-bot/juju-core/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
cmd/jujud/bootstrap.go (+1/-1)
To merge this branch: bzr merge lp:~mfoord/juju-core/local-mongo
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+220830@code.launchpad.net
To post a comment you must log in.
lp:~mfoord/juju-core/local-mongo updated
2747. By Michael Foord

Always use HA, even for local provider

Revision history for this message
William Reade (fwereade) wrote :

Whoa. Does that work? Can we just drop the conditional on withHA then? (Where else are we still using shouldEnableHA?)

Revision history for this message
John A Meinel (jameinel) wrote :

So this works for me, it worked for Tim, but Ian saw failures and CI saw failures, which is why Ian wrote the withHA hack in the first place.

If we can get this to work in CI, then definitely we want to just get rid of all the shouldEnableHA functionality.

Revision history for this message
Andrew Wilkins (axwalk) wrote :

Superseded by https://code.launchpad.net/~mfoord/juju-core/local-replset/+merge/221117

Unmerged revisions

2747. By Michael Foord

Always use HA, even for local provider

2746. By Michael Foord

Merge

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmd/jujud/bootstrap.go'
2--- cmd/jujud/bootstrap.go 2014-05-23 05:10:50 +0000
3+++ cmd/jujud/bootstrap.go 2014-05-23 16:52:00 +0000
4@@ -185,7 +185,7 @@
5 }
6
7 logger.Debugf("calling ensureMongoServer")
8- withHA := shouldEnableHA(agentConfig)
9+ withHA := true
10 err = ensureMongoServer(
11 agentConfig.DataDir(),
12 agentConfig.Value(agent.Namespace),

Subscribers

People subscribed via source and target branches

to status/vote changes: