Merge ~mfo/grub:lp1965983 into ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu

Proposed by Mauricio Faria de Oliveira
Status: Merged
Merge reported by: Julian Andres Klode
Merged at revision: 57c233fc6eb7bca647935f31a4ee25703af96ae0
Proposed branch: ~mfo/grub:lp1965983
Merge into: ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu
Diff against target: 35 lines (+11/-6)
1 file modified
debian/patches/ubuntu-zfs-enhance-support.patch (+11/-6)
Reviewer Review Type Date Requested Status
Julian Andres Klode Pending
Review via email: mp+429027@code.launchpad.net

Description of the change

Hi Julian,

This MR is just MR [1] modified to edit the original patch instead of adding a fixup patch
(per our IRC chat last Thursday).

[1] https://code.launchpad.net/~arbell/grub/+git/grub/+merge/417575

To post a comment you must log in.
Revision history for this message
Julian Andres Klode (juliank) wrote :

Rebased and merged

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/patches/ubuntu-zfs-enhance-support.patch b/debian/patches/ubuntu-zfs-enhance-support.patch
2index f71d771..2d0a977 100644
3--- a/debian/patches/ubuntu-zfs-enhance-support.patch
4+++ b/debian/patches/ubuntu-zfs-enhance-support.patch
5@@ -14,7 +14,8 @@ Subject: UBUNTU: Enhance ZFS grub support
6
7 Author: Jean-Baptiste Lallement <jean-baptiste@ubuntu.com>
8 Author: Didier Roche <didrocks@ubuntu.com>
9-Last-Update: 2020-08-06
10+Author: Adam R Bell <a_0x07@protonmail.ch>
11+Last-Update: 2022-08-27
12 Patch-Name: ubuntu-zfs-enhance-support.patch
13
14 Signed-off-by: Didier Roche <didier.roche@canonical.com>
15@@ -568,11 +569,15 @@ index 0000000..f321fe2
16 +
17 + umount "${mntdir}" || true
18 + # We needed to look in / for snapshots on root dataset, umount the snapshot for etc before zfs lazily unmount it
19-+ case "${etc_dir}" in /.zfs/snapshot/*/etc)
20-+ snapshot_path="$(findmnt -n -o TARGET -T "${etc_dir}")"
21-+ umount "${snapshot_path}" || true
22-+ ;;
23-+ esac
24++ # This process only needs to run if the snapshot contains an .../etc path,
25++ # otherwise the build process may silently fail and produce no kernel lines in grub.cfg
26++ if [ -e "${etc_dir}" ]; then
27++ case "${etc_dir}" in /.zfs/snapshot/*/etc)
28++ snapshot_path="$(findmnt -n -o TARGET -T "${etc_dir}")"
29++ umount "${snapshot_path}" || true
30++ ;;
31++ esac
32++ fi
33 +}
34 +
35 +# Scan available boot options and returns in a formatted list

Subscribers

People subscribed via source and target branches