fix-grub-cmdline-linux-default : lp:~mfo/charm-sysconfig : Git : Code : charm-sysconfig

Get this branch:: git clone -b fix-grub-cmdline-linux-default https://git.launchpad.net/~mfo/charm-sysconfig

Only Mauricio Faria de Oliveira can upload to this branch. If you are Mauricio Faria de Oliveira please log in for upload directions.

Xav Paice (community): Approve on 2020-07-08

Adam Dyess (community): Approve on 2020-07-07

Zachary Zehring (community): Approve on 2020-06-23

Branch information

grub.j2: fix grub-config-flags that use $GRUB_CMDLINE_LINUX_DEFAULT

The suggestion in README.md to 'add or keep kernel parameters you
had previously configured' does not work -- it's actually ignored.

This happens because grub-config-flags is evaluated in grub.j2
after we already set GRUB_CMDLINE_LINUX_DEFAULT, so it is gone.

Using it it grub-config-flags does not keep the previous value.

To fix that, move it to the first thing done in grub.j2, and
change our first assignment of GRUB_CMDLINE_LINUX_DEFAULT to
include it.

And now that our first assignment includes it, make sure it
is cleared up (ignored) if grub-config-flags is not set.

This is to keep the current behavior to ignore/override it.

Signed-off-by: Mauricio Faria de Oliveira <email address hidden>

Add focal support on func tests

Ported sysctl features to this charm harvested from sysctl charm

Reviewed-on: https://code.launchpad.net/~llama-charmers/charm-sysconfig/+git/charm-sysconfig/+merge/382243
Reviewed-by: Alvaro Uria <email address hidden>
Reviewed-by: Paul Goins <email address hidden>

Fix linting errors

address config description formatting

Fix config.yaml to describe sysctl exactly as other charms describe

remove b64 encoded sysctl yaml data

functional tests pass

updating from review comments

made sysctrl config option b64 encoded

»