Merge lp:~mfisch/unity/unity-lp1215951 into lp:unity

Proposed by Matt Fischer
Status: Rejected
Rejected by: Christopher Townsend
Proposed branch: lp:~mfisch/unity/unity-lp1215951
Merge into: lp:unity
Diff against target: 15 lines (+7/-0)
1 file modified
com.canonical.Unity.gschema.xml (+7/-0)
To merge this branch: bzr merge lp:~mfisch/unity/unity-lp1215951
Reviewer Review Type Date Requested Status
Christopher Townsend Disapprove
PS Jenkins bot (community) continuous-integration Approve
Michael Zanetti (community) Needs Information
Review via email: mp+182185@code.launchpad.net

Commit message

Adds a gsetting for the infographic URI

Description of the change

Adds a gsetting for the infographic URI, needed to fix https://bugs.launchpad.net/unity8/+bug/1215951

To post a comment you must log in.
Revision history for this message
Michael Zanetti (mzanetti) wrote :

shouldn't this change rather be in /usr/share/glib-2.0/schemas/com.canonical.unity-greeter.gschema.xml ?

review: Needs Information
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Christopher Townsend (townsend) wrote :

I don't believe this is intended for lp:unity, so I'm going to mark this as rejected. If I'm mistaken, please let me know and we'll figure out why this is needed for Unity 7.

review: Disapprove

Unmerged revisions

3478. By Matt Fischer

Add a gsetting for the infographic URI

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'com.canonical.Unity.gschema.xml'
2--- com.canonical.Unity.gschema.xml 2013-08-01 19:13:16 +0000
3+++ com.canonical.Unity.gschema.xml 2013-08-26 18:55:32 +0000
4@@ -73,4 +73,11 @@
5 <description>The scopes listed in the scope bar will be ordered according to this list.</description>
6 </key>
7 </schema>
8+ <schema path="/com/canonical/unity/greeter/" id="com.canonical.Unity.Greeter" gettext-domain="unity">
9+ <key type="s" name="infographic-uri">
10+ <default>'file:///usr/share/unity8/Greeter/graphics/infographic_circle.png'</default>
11+ <summary>Path to the infographic circle</summary>
12+ <description>Path to the infographic circl</description>
13+ </key>
14+ </schema>
15 </schemalist>