Ubuntu

Merge lp:~mfisch/ubuntu/precise/live-manual/live-manual-fix-ftbfs-831392 into lp:ubuntu/precise/live-manual

Proposed by Matt Fischer on 2012-03-04
Status: Merged
Merged at revision: 30
Proposed branch: lp:~mfisch/ubuntu/precise/live-manual/live-manual-fix-ftbfs-831392
Merge into: lp:ubuntu/precise/live-manual
Diff against target: 47 lines (+11/-3) 3 files modified
To merge this branch: bzr merge lp:~mfisch/ubuntu/precise/live-manual/live-manual-fix-ftbfs-831392
Reviewer Review Type Date Requested Status
Timo Aaltonen Approve on 2012-03-07
Ubuntu branches 2012-03-04 Pending
Review via email: mp+95793@code.launchpad.net

Description of the Change

I have tracked down the FTBFS issue, it is because that inside the chroot the environment (specifically LC_ALL is set to "C") and so when it tries to process the manuals for the other languages, like de, it bails when it sees "invalid byte sequence in US-ASCII". Then later on it really fails when it can't find the localized manuals to complete the processing.

What the fix is is that you need to install the us locale in your chroot and setting LC_ALL before the build. I think the key here is that the environment is <something>.UTF-8, but there's no reason not to use en_US, the other manuals are not broken by this process from what I see.

This failure also explains to me why it builds fine outside a chroot on my dev box or in a regular VM.

To post a comment you must log in.
Stefano Rivera (stefanor) wrote :

This issue isn't specific to Ubuntu, so it would be nice to have a generic solution that would work for Debian too.

Debian doesn't have langpacks. It does have locales-all, but that's huge, and takes forever to install. So, the best solution is usually to generate a locale during install (python-djvulibre is an example of a package doing something like this).

Matt Fischer (mfisch) wrote :

From what I can tell it builds fine for debian since they have binary packages for it. I assumed that their build systems already had locales installed. Can you confirm that this is also broken for them?

Matt Fischer (mfisch) wrote :

Okay, so I see what python-djvulibre does (another package on the FTBFS list btw), I can try that method and remove the new dependency. I'd still like to know how this builds for debian and not for us or perhaps I'm mistaken.

Matt Fischer (mfisch) wrote :

Stefano,

I'm able to get it to build by doing this in debian/rules:

%:
        mkdir -p debian/tmp/locale/
        localedef -f UTF-8 -i en_US ./debian/tmp/locale/en_US.UTF-8/
        export LOCPATH=$(CURDIR)/debian/tmp/locale/ && \
        export LC_ALL=en_US.UTF-8 && \
        dh ${@}

Doing those steps in override_dh_builddeb didn't do it.

I also removed the changes to the control file. If this is what you're looking for, I'll push a new version. Let me know.

Timo Aaltonen (tjaalton) :
review: Approve

Preview Diff

1=== modified file 'debian/changelog'
2--- debian/changelog 2011-12-04 10:25:10 +0000
3+++ debian/changelog 2012-03-04 18:07:20 +0000
4@@ -1,3 +1,10 @@
5+live-manual (1:3.0~a9-1ubuntu1) precise; urgency=low
6+
7+ * fix FTBFS by adding a dependency on language-pack-en and setting the
8+ LC_ALL to en_US.UTF-8 (LP: #831392)
9+
10+ -- Matthew Fischer <matthew.fischer@canonical.com> Sat, 03 Mar 2012 21:36:04 -0700
11+
12 live-manual (1:3.0~a9-1) unstable; urgency=low
13
14 [ chals ]
15
16=== modified file 'debian/control'
17--- debian/control 2011-12-04 10:25:10 +0000
18+++ debian/control 2012-03-04 18:07:20 +0000
19@@ -1,12 +1,13 @@
20 Source: live-manual
21 Section: doc
22 Priority: optional
23-Maintainer: Debian Live Project <debian-live@lists.debian.org>
24+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
25+XSBC-Original-Maintainer: Debian Live Project <debian-live@lists.debian.org>
26 Uploaders:
27 Ben Armstrong <synrg@sanctuary.nslug.ns.ca>,
28 Daniel Baumann <daniel@debian.org>,
29 Chris Lamb <lamby@debian.org>
30-Build-Depends: debhelper (>= 8), ruby, libnokogiri-ruby
31+Build-Depends: debhelper (>= 8), ruby, libnokogiri-ruby, language-pack-en
32 Build-Depends-Indep: sisu-complete (>= 3), po4a
33 Standards-Version: 3.9.2
34 Homepage: http://live.debian.net/devel/live-manual/
35
36=== modified file 'debian/rules'
37--- debian/rules 2011-12-04 10:25:10 +0000
38+++ debian/rules 2012-03-04 18:07:20 +0000
39@@ -1,7 +1,7 @@
40 #!/usr/bin/make -f
41
42 %:
43- dh ${@}
44+ LC_ALL=en_US.UTF-8 dh ${@}
45
46 override_dh_builddeb:
47 dh_builddeb -- -Zgzip -z9

Subscribers

People subscribed via source and target branches

to all changes: