Merge lp:~mfisch/ubuntu-accomplishments-daemon/ubuntu-accomplishments-daemon-lp1009630 into lp:ubuntu-accomplishments-daemon
Status: | Merged |
---|---|
Merged at revision: | 111 |
Proposed branch: | lp:~mfisch/ubuntu-accomplishments-daemon/ubuntu-accomplishments-daemon-lp1009630 |
Merge into: | lp:ubuntu-accomplishments-daemon |
Diff against target: |
297 lines (+102/-42) 2 files modified
accomplishments/daemon/api.py (+65/-40) accomplishments/daemon/tests/tests.py (+37/-2) |
To merge this branch: | bzr merge lp:~mfisch/ubuntu-accomplishments-daemon/ubuntu-accomplishments-daemon-lp1009630 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Accomplishments Daemon Developers | Pending | ||
Review via email: mp+115786@code.launchpad.net |
Description of the change
1) Whitespace clean-up (next time I will fix all of this so I dont have to keep doing it)
2) tests for run_script/
3) fixes 1009630 - checks to ensure all required info for a given accomID is there before running the script
4) I rewrote run_scripts() so it's cleaner and easier to follow the flow.
If you look at _is_all_
Here's the relevant section of log after I run it:
2012-07-19 17:37:19+0100 [-] Adding to scripts queue: ['ubuntu-
2012-07-19 17:37:19+0100 [-] --- Starting Running Scripts - 2 items on the queue ---
2012-07-19 17:37:19+0100 [-] Running ubuntu-
2012-07-19 17:37:19+0100 [-] launchpad-email is missing for ubuntu-
2012-07-19 17:37:19+0100 [-] ...Extra information required, but not available, skipping
2012-07-19 17:37:19+0100 [-] Running ubuntu-
2012-07-19 17:37:19+0100 [-] askubuntu-user-url is missing for ubuntu-
2012-07-19 17:37:19+0100 [-] ...Extra information required, but not available, skipping
2012-07-19 17:37:19+0100 [-] The queue is now empty - stopping the scriptrunner.
2012-07-19 17:37:19+0100 [-] --- Emptied the scripts queue in 0.00 seconds---