Merge lp:~mfisch/telepathy-ofono/remove_debug_print into lp:telepathy-ofono

Proposed by Matt Fischer
Status: Needs review
Proposed branch: lp:~mfisch/telepathy-ofono/remove_debug_print
Merge into: lp:telepathy-ofono
Diff against target: 11 lines (+0/-1)
1 file modified
connection.cpp (+0/-1)
To merge this branch: bzr merge lp:~mfisch/telepathy-ofono/remove_debug_print
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Tiago Salem Herrmann (community) Approve
Review via email: mp+178172@code.launchpad.net

Commit message

Removes the debug message "onTryRegister"

Description of the change

Approximately every 5 seconds, telepathy-ofono logs "onTryRegister" to the dbus.log in ~phablet/.cache/upstart. This is annoying for trying to debug other issues and just wastes disk space. So I'm assuming it's not really helpful for you guys, so can we remove it per this MP?

To post a comment you must log in.
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

looks good.
I left this debug there during development and forgot to remove it.
Thanks.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/telepathy-ofono-autolanding/4/
Executed test runs:

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:35
http://jenkins.qa.ubuntu.com/job/telepathy-ofono-ci/5/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/telepathy-ofono-ci/5/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

35. By Matt Fischer

Quiet the onTryRegister message

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'connection.cpp'
2--- connection.cpp 2013-06-01 01:50:34 +0000
3+++ connection.cpp 2013-08-01 22:05:34 +0000
4@@ -151,7 +151,6 @@
5
6 void oFonoConnection::onTryRegister()
7 {
8- qDebug() << "onTryRegister";
9 bool networkRegistered = isNetworkRegistered();
10 if (networkRegistered) {
11 setOnline(networkRegistered);

Subscribers

People subscribed via source and target branches