Merge lp:~mfisch/charms/precise/tracks/trunk into lp:charms/tracks

[Matt Fischer]

Fix for https://bugs.launchpad.net/charms/+source/tracks/+bug/1155358

The issue was that tracks bundled an ancient gem that had links to keyfiles on the original author's website, the files were moved or removed and the gem broke. According to discussions upstream the charm was "unmaintainable" and therefore removed in a recent version.

https://www.assembla.com/spaces/tracks-tickets/tickets/1272#/activity/ticket:

[Marco Ceppi (marcoceppi)]

Hi Matt! Thanks for the submission and sorry for the delay. Your changes look good for this (everything installs and moves to a started state). However, when I added the MySQL connection a relation error occurred[1]. Could you look into why this happened and repair? I understand it's broken in it's current state, but this merge (while addresses that issue) appears to break the charm elsewhere. Also, during my investigation I noticed you don't have a config-changed hook and opened this bug[2] to have that rectified but it's not a blocker for getting this merge done.

When you're ready for review make sure to re-assign "charmers" as the reviewer for it to appear back in the queue again.

[1]: http://paste.ubuntu.com/5702667/
[2]: https://bugs.launchpad.net/charms/+source/tracks/+bug/1168520

review: Needs Fixing

[Marius B. Kotsbak (mariusko)]

Any progress here?

[Jorge Castro (jorge)]

This MP has been languishing, since it's abandoned I'll go ahead and close this out.

review: Needs Fixing

Unmerged revisions

5. By Matt Fischer on 2013-04-01

fixing the issue with has_many_polymorphs that prevented tracks from starting. A newer upstream fixed the problem.

=== modified file 'hooks/install'
--- hooks/install	2013-02-21 03:31:54 +0000
+++ hooks/install	2013-04-01 20:45:31 +0000
@@ -3,6 +3,7 @@
 # ToDo:
 # - remove imagemagick?
 
+VERSION=2.2.1
 set -eux
 
 juju-log "installing pre-reqs"
@@ -12,11 +13,10 @@
 imagemagick graphicsmagick libgraphicsmagick1-dev librmagick-ruby \
 libxslt-dev libxml2-dev pwgen rubygems mysql-client wget
 
-juju-log "installing tracks"
-wget -O tracks.zip https://github.com/TracksApp/tracks/zipball/v2.1
+juju-log "installing tracks v${VERSION}"
+wget -O tracks.zip https://github.com/TracksApp/tracks/archive/v${VERSION}.zip
 unzip tracks.zip
-mv TracksApp-tracks-* tracks
-cd tracks
+cd tracks-${VERSION}
 chmod -R 664 *
 find -type d -exec chmod a+x '{}' \;
 chmod -R a+x script/*