Merge lp:~methanal-developers/methanal/1350779-lookup-infinite-recursion into lp:methanal

Proposed by Tristan Seligmann
Status: Merged
Approved by: Jonathan Jacobs
Approved revision: 206
Merged at revision: 206
Proposed branch: lp:~methanal-developers/methanal/1350779-lookup-infinite-recursion
Merge into: lp:methanal
Diff against target: 27 lines (+5/-5)
1 file modified
methanal/js/Methanal/Widgets.js (+5/-5)
To merge this branch: bzr merge lp:~methanal-developers/methanal/1350779-lookup-infinite-recursion
Reviewer Review Type Date Requested Status
Jonathan Jacobs Approve
Review via email: mp+229008@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jonathan Jacobs (jjacobs) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'methanal/js/Methanal/Widgets.js' (properties changed: -x to +x)
2--- methanal/js/Methanal/Widgets.js 2014-07-15 12:41:25 +0000
3+++ methanal/js/Methanal/Widgets.js 2014-07-31 10:19:00 +0000
4@@ -1428,11 +1428,6 @@
5 // Trigger Lookup.onChange so the parent form refreshes validators.
6 self.widgetParent.onChange(control.node, self._initialisedOnce);
7
8- if (!self.valid) {
9- self.setResults([]);
10- return;
11- }
12-
13 // Don't trigger when the result input is changed or when there are
14 // validation errors.
15 if (control.name === '__result__') {
16@@ -1440,6 +1435,11 @@
17 return;
18 }
19
20+ if (!self.valid) {
21+ self.setResults([]);
22+ return;
23+ }
24+
25 // Gather form values from all the filter attributes.
26 var data = {};
27 for (var controlName in self.controls) {

Subscribers

People subscribed via source and target branches

to all changes: