Merge lp:~methanal-developers/methanal/1311615-tabview-async-content-factories into lp:methanal

Proposed by Jonathan Jacobs
Status: Merged
Merged at revision: 204
Proposed branch: lp:~methanal-developers/methanal/1311615-tabview-async-content-factories
Merge into: lp:methanal
Diff against target: 42 lines (+15/-6)
1 file modified
methanal/widgets.py (+15/-6)
To merge this branch: bzr merge lp:~methanal-developers/methanal/1311615-tabview-async-content-factories
Reviewer Review Type Date Requested Status
Methanal maintainers Pending
Review via email: mp+216865@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'methanal/widgets.py'
2--- methanal/widgets.py 2014-03-14 13:48:19 +0000
3+++ methanal/widgets.py 2014-04-23 11:39:44 +0000
4@@ -1034,9 +1034,12 @@
5
6 @expose
7 def getContent(self, nodeID=None):
8- content = self.contentFactory()
9- content.setFragmentParent(self)
10- return content
11+ def _setFragmentParent(content):
12+ content.setFragmentParent(self)
13+ return content
14+ d = maybeDeferred(self.contentFactory)
15+ d.addCallback(_setFragmentParent)
16+ return d
17
18
19 @renderer
20@@ -1066,7 +1069,9 @@
21
22 @renderer
23 def tabContent(self, req, tag):
24- return tag[self.getContent()]
25+ d = self.getContent()
26+ d.addCallback(tag.__getitem__)
27+ return d
28
29
30 def updateRemoteContent(self):
31@@ -1100,8 +1105,12 @@
32 """
33 Force the remote content to be updated.
34 """
35- return self.callRemote(
36- 'setContentFromWidgetInfo', self.getContent(), u'content')
37+ def _callRemote(content):
38+ return self.callRemote(
39+ 'setContentFromWidgetInfo', content, u'content')
40+ d = self.getContent()
41+ d.addCallback(_callRemote)
42+ return d
43
44
45

Subscribers

People subscribed via source and target branches

to all changes: