Merge lp:~methanal-developers/methanal/1092198-inputs-set-name-attribute into lp:methanal

[William Seligmann]

[Darren Dormer (ddormer)]

The method "renderName" should just be called "name" as @renderer implies the method will be used to render.

review: Needs Fixing

[Tristan Seligmann (mithrandi)]

Actually, it can't be named "name" since the attribute storing the name string is already called that :/

[Tristan Seligmann (mithrandi)]

review: Approve

[Darren Dormer (ddormer)]

review: Approve

=== modified file 'methanal/themes/methanal-base/methanal-check-input.html'
--- methanal/themes/methanal-base/methanal-check-input.html	2011-07-04 14:15:27 +0000
+++ methanal/themes/methanal-base/methanal-check-input.html	2013-02-19 13:10:33 +0000
@@ -1,6 +1,7 @@
 <div xmlns:nevow="http://nevow.com/ns/nevow/0.1" xmlns:athena="http://divmod.org/ns/athena/0.7" nevow:render="liveElement">
     <label class="methanal-check-input-label" nevow:render="checkLabel">
         <input class="methanal-check-input" type="checkbox" nevow:render="value">
+        	<nevow:attr name="name" nevow:render="renderName" />
             <athena:handler event="onclick" handler="onChange" />
         </input>
     </label>

=== modified file 'methanal/themes/methanal-base/methanal-multicheck-input.html'
--- methanal/themes/methanal-base/methanal-multicheck-input.html	2011-07-04 14:15:27 +0000
+++ methanal/themes/methanal-base/methanal-multicheck-input.html	2013-02-19 13:10:33 +0000
@@ -7,6 +7,7 @@
             <div nevow:pattern="option">
                 <label>
                     <input type="checkbox">
+                        <nevow:attr name="name" nevow:render="renderName" />
                         <athena:handler event="onchange" handler="onChange" />
                         <nevow:attr name="value"><nevow:slot name="value" /></nevow:attr>
                     </input>

=== modified file 'methanal/themes/methanal-base/methanal-multiselect-input.html'
--- methanal/themes/methanal-base/methanal-multiselect-input.html	2011-07-11 11:33:39 +0000
+++ methanal/themes/methanal-base/methanal-multiselect-input.html	2013-02-19 13:10:33 +0000
@@ -1,5 +1,6 @@
 <div xmlns:nevow="http://nevow.com/ns/nevow/0.1" xmlns:athena="http://divmod.org/ns/athena/0.7" nevow:render="liveElement">
     <select class="methanal-input methanal-multiselect" multiple="multiple">
+        <nevow:attr name="name" nevow:render="renderName" />
         <athena:handler event="onchange" handler="onChange" />
         <nevow:invisible nevow:render="options">
             <optgroup nevow:pattern="optgroup">

=== modified file 'methanal/themes/methanal-base/methanal-select-input.html'
--- methanal/themes/methanal-base/methanal-select-input.html	2011-07-04 14:15:27 +0000
+++ methanal/themes/methanal-base/methanal-select-input.html	2013-02-19 13:10:33 +0000
@@ -1,5 +1,6 @@
 <div xmlns:nevow="http://nevow.com/ns/nevow/0.1" xmlns:athena="http://divmod.org/ns/athena/0.7" nevow:render="liveElement">
     <select class="methanal-input">
+    	<nevow:attr name="name" nevow:render="renderName" />
         <athena:handler event="onchange" handler="onChange" />
         <nevow:invisible nevow:render="options">
             <optgroup nevow:pattern="optgroup">

=== modified file 'methanal/themes/methanal-base/methanal-text-area-input.html'
--- methanal/themes/methanal-base/methanal-text-area-input.html	2011-07-04 14:15:27 +0000
+++ methanal/themes/methanal-base/methanal-text-area-input.html	2013-02-19 13:10:33 +0000
@@ -1,5 +1,6 @@
 <div xmlns:nevow="http://nevow.com/ns/nevow/0.1" xmlns:athena="http://divmod.org/ns/athena/0.7" nevow:render="liveElement">
     <textarea class="methanal-input" type="text" nevow:render="value">
+    	<nevow:attr name="name" nevow:render="renderName" />
         <athena:handler event="onchange" handler="onChange" />
     </textarea>
 </div>

=== modified file 'methanal/themes/methanal-base/methanal-text-input.html'
--- methanal/themes/methanal-base/methanal-text-input.html	2011-07-11 11:33:39 +0000
+++ methanal/themes/methanal-base/methanal-text-input.html	2013-02-19 13:10:33 +0000
@@ -1,6 +1,7 @@
 <div xmlns:nevow="http://nevow.com/ns/nevow/0.1" xmlns:athena="http://divmod.org/ns/athena/0.7" nevow:render="liveElement">
     <input class="methanal-input" type="text">
         <nevow:attr name="value" nevow:render="value" />
+        <nevow:attr name="name" nevow:render="renderName" />
         <athena:handler event="onchange" handler="onChange" />
         <athena:handler event="onkeyup" handler="onKeyUp" />
         <athena:handler event="onblur" handler="onBlur" />

=== modified file 'methanal/themes/methanal-base/methanal-verified-password-input.html'
--- methanal/themes/methanal-base/methanal-verified-password-input.html	2011-07-11 11:33:39 +0000
+++ methanal/themes/methanal-base/methanal-verified-password-input.html	2013-02-19 13:10:33 +0000
@@ -1,6 +1,7 @@
 <div xmlns:nevow="http://nevow.com/ns/nevow/0.1" xmlns:athena="http://divmod.org/ns/athena/0.7" nevow:render="liveElement">
     <input class="methanal-input" type="password">
         <nevow:attr name="value" nevow:render="value" />
+        <nevow:attr name="name" nevow:render="renderName" />
         <athena:handler event="onchange" handler="onChange" />
         <athena:handler event="onkeyup" handler="onKeyUp" />
         <athena:handler event="onblur" handler="onBlur" />

=== modified file 'methanal/view.py'
--- methanal/view.py	2012-07-13 20:54:14 +0000
+++ methanal/view.py	2013-02-19 13:10:33 +0000
@@ -522,6 +522,14 @@
         return tag[value]
 
 
+    @renderer
+    def renderName(self, req, tag):
+        """
+        Render the input's name.
+        """
+        return tag[self.name]
+
+
     def invoke(self, data):
         """
         Set the model parameter's value from form data.