Merge lp:~mesilliac/ubuntu/quantal/bluez/fix-dinovo-edge-keyboard into lp:ubuntu/quantal/bluez

Proposed by tommy
Status: Merged
Merge reported by: Marc Deslauriers
Merged at revision: not available
Proposed branch: lp:~mesilliac/ubuntu/quantal/bluez/fix-dinovo-edge-keyboard
Merge into: lp:ubuntu/quantal/bluez
Diff against target: 43 lines (+23/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/dinovo_edge_keyboard.patch (+16/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~mesilliac/ubuntu/quantal/bluez/fix-dinovo-edge-keyboard
Reviewer Review Type Date Requested Status
Marc Deslauriers Approve
Ubuntu branches Pending
Review via email: mp+117001@code.launchpad.net

Description of the change

Use "hidraw" in stead of "hiddev" for Logitech device 046d:c714 - diNovo Edge Keyboard.

Tested on amd64 with provided Logitech bluetooth dongle (comes with keyboard).

The dongle is unable to act as a generic bluetooth dongle,
but a working keyboard is most important.

Note: this may be a firmware problem.
See https://bugs.launchpad.net/ubuntu/+source/bluez/+bug/269851/comments/31

Tested with patch:
keyboard working in BIOS: yes
keyboard working in GRUB: yes
keyboard working in recovery console: yes
keyboard working in graphical login: yes
keyboard working in ubuntu: yes

In all testable cases, the touchpad seems to also work.

Untested:
connecting to a different bluetooth dongle with the keyboard.
Not sure if this is supposed to work.
I had all kinds of trouble trying to do this a while back,
so recommend this simple fix be applied for now.

Open questions:
not sure if other devices also need to be also special-cased to get them working,
asked https://bugs.launchpad.net/ubuntu/+source/bluez/+bug/269851/comments/53
but have recieved no response yet,
might be just this device which still has a problem.

The patch is straight-forward and obvious,
so if other devices need the same treatment,
modifying it is easy.

Related bug reports:
LP #269851
LP #306421
debbugs #355497
debbugs #383373

To post a comment you must log in.
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

ACK on the patch. I have uploaded it to quantal with a couple of changes:
1- I've added the bug reference to the changelog
2- I've added headers to the patch as per http://dep.debian.net/deps/dep3/

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-07-12 14:53:13 +0000
3+++ debian/changelog 2012-07-27 04:53:22 +0000
4@@ -1,3 +1,9 @@
5+bluez (4.101-0ubuntu3) UNRELEASED; urgency=low
6+
7+ * debian/patches/dinovo_edge_keyboard.patch: support diNovo Edge keyboard.
8+
9+ -- Tommy <mesilliac@gmail.com> Fri, 27 Jul 2012 15:15:48 +1200
10+
11 bluez (4.101-0ubuntu2) quantal; urgency=low
12
13 * debian/control: enable autopkgtest tests; add XS-Testsuite.
14
15=== added file 'debian/patches/dinovo_edge_keyboard.patch'
16--- debian/patches/dinovo_edge_keyboard.patch 1970-01-01 00:00:00 +0000
17+++ debian/patches/dinovo_edge_keyboard.patch 2012-07-27 04:53:22 +0000
18@@ -0,0 +1,16 @@
19+Index: bluez/scripts/bluetooth-hid2hci.rules
20+===================================================================
21+--- bluez.orig/scripts/bluetooth-hid2hci.rules 2012-07-27 14:28:05.426609000 +1200
22++++ bluez/scripts/bluetooth-hid2hci.rules 2012-07-27 14:40:01.949356631 +1200
23+@@ -11,7 +11,10 @@
24+ RUN+="hid2hci --method=dell --devpath=%p", ENV{HID2HCI_SWITCH}="1"
25+
26+ # Logitech devices
27+-KERNEL=="hiddev*", ATTRS{idVendor}=="046d", ATTRS{idProduct}=="c70[345abce]|c71[34bc]", \
28++KERNEL=="hiddev*", ATTRS{idVendor}=="046d", ATTRS{idProduct}=="c70[345abce]|c71[3bc]", \
29++ RUN+="hid2hci --method=logitech-hid --devpath=%p"
30++# Logitech, Inc. diNovo Edge Keyboard
31++KERNEL=="hidraw*", ATTRS{idVendor}=="046d", ATTRS{idProduct}=="c714", \
32+ RUN+="hid2hci --method=logitech-hid --devpath=%p"
33+
34+ ENV{DEVTYPE}!="usb_device", GOTO="hid2hci_end"
35
36=== modified file 'debian/patches/series'
37--- debian/patches/series 2012-07-04 13:28:49 +0000
38+++ debian/patches/series 2012-07-27 04:53:22 +0000
39@@ -8,3 +8,4 @@
40 enable_audio_profiles.patch
41 09_fix_ftbfs_with_c99.patch
42 sbc_mmx.patch
43+dinovo_edge_keyboard.patch

Subscribers

People subscribed via source and target branches

to all changes: