Merge ~mertkirpici/charm-thruk-master:bseng/553 into charm-thruk-master:master

Proposed by Mert Kirpici
Status: Merged
Approved by: Eric Chen
Approved revision: 6d3f494210616bd78d67ed3910afc6b6591ac5e1
Merged at revision: 2c2bb631c629221973ebe4ba18e2668c08d9b921
Proposed branch: ~mertkirpici/charm-thruk-master:bseng/553
Merge into: charm-thruk-master:master
Diff against target: 12 lines (+1/-1)
1 file modified
Makefile (+1/-1)
Reviewer Review Type Date Requested Status
Erhan Sunar (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
BootStack Reviewers Pending
Review via email: mp+433535@code.launchpad.net

Commit message

Fix unittests target

Description of the change

unittests target must depend on submodules-update

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Erhan Sunar (esunar) wrote :

LGTM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 2c2bb631c629221973ebe4ba18e2668c08d9b921

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Makefile b/Makefile
2index e9e0f20..374f643 100644
3--- a/Makefile
4+++ b/Makefile
5@@ -65,7 +65,7 @@ proof:
6 @echo "Running charm proof"
7 @charm proof
8
9-unittests:
10+unittests: submodules-update
11 @echo "Running unit tests"
12 @tox -e unit
13

Subscribers

People subscribed via source and target branches

to all changes: