Merge ~mertkirpici/charm-sysconfig:lp/1915167 into charm-sysconfig:master

[Mert Kirpici]

reactive/sysconfig.py: create sysctl config file upon installation

See commit messages

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Eric Chen (eric-chen)]

review: Needs Information

[Eric Chen (eric-chen)]

review: Approve

[Giuseppe Petralia (peppepetra)]

lgtm, thanks

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision d0a9456208b09d9e2b6497ee875cc7ac61f29520

diff --git a/src/reactive/sysconfig.py b/src/reactive/sysconfig.py
index 7ac0a44..1137304 100644
--- a/src/reactive/sysconfig.py
+++ b/src/reactive/sysconfig.py
@@ -64,6 +64,7 @@ def install_sysconfig():
     syshelper.update_systemd_system_file()
     syshelper.update_systemd_resolved()
     syshelper.update_irqbalance()
+    syshelper.update_sysctl()
     set_flag("sysconfig.installed")
     update_status()
 
diff --git a/src/tests/functional/juju_tools.py b/src/tests/functional/juju_tools.py
index 71b4aac..9989734 100644
--- a/src/tests/functional/juju_tools.py
+++ b/src/tests/functional/juju_tools.py
@@ -64,6 +64,17 @@ class JujuTools:
         print("Calling remote cmd: " + python_cmd)
         return await self.remote_object(imports, python_cmd, target)
 
+    async def file_exists(self, path, target):
+        """Run os.path.isfile() on a file.
+
+        :param path: File path
+        :param target: Unit object or unit name string
+        """
+        imports = "import os;"
+        python_cmd = 'os.path.isfile("{}")'.format(path)
+        print("Calling remote cmd: " + python_cmd)
+        return await self.remote_object(imports, python_cmd, target)
+
     async def file_contents(self, path, target):
         """Return the contents of a file.
 
diff --git a/src/tests/functional/test_deploy.py b/src/tests/functional/test_deploy.py
index 28a52ef..cc74f4c 100644
--- a/src/tests/functional/test_deploy.py
+++ b/src/tests/functional/test_deploy.py
@@ -126,6 +126,10 @@ async def test_default_config(app, jujutools):
     assert "GRUB_DEFAULT" not in grub_content
     assert "default_hugepagesz" not in grub_content
 
+    sysctl_path = '/etc/sysctl.d/90-charm-sysconfig.conf'
+    sysctl_exists = await jujutools.file_exists(sysctl_path, unit)
+    assert sysctl_exists
+
     systemd_path = "/etc/systemd/system.conf"
     systemd_content = await jujutools.file_contents(systemd_path, unit)
     systemd_valid = True