Merge ~mertkirpici/charm-openstack-service-checks:lp/1998094 into charm-openstack-service-checks:master

Proposed by Mert Kirpici
Status: Merged
Approved by: Ramesh Sattaru
Approved revision: 8aec4d52db16dcb63ef89a93849bcae197a7fc86
Merged at revision: d679b34356ff6d50c51f25e8a929105a6af81cdb
Proposed branch: ~mertkirpici/charm-openstack-service-checks:lp/1998094
Merge into: charm-openstack-service-checks:master
Diff against target: 23 lines (+8/-4)
1 file modified
src/tox.ini (+8/-4)
Reviewer Review Type Date Requested Status
Ramesh Sattaru (community) Approve
Erhan Sunar (community) Approve
prod-jenkaas-bootstack (community) continuous-integration Approve
BootStack Reviewers Pending
Review via email: mp+433724@code.launchpad.net

Commit message

Close LP #1998094

Description of the change

flake8 6.0.0 does not like it when the inline comments are on the same
line as the ignored rule.

To post a comment you must log in.
Revision history for this message
Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Erhan Sunar (esunar) :
review: Approve
Revision history for this message
Ramesh Sattaru (rameshcan) wrote :

As discussed, can you please check the feasibility of fixing the warnings

review: Needs Fixing
Revision history for this message
Mert Kirpici (mertkirpici) wrote :

As discussed, we are not going to go with the TODO's just now. So this is ready to get merged.

Revision history for this message
Ramesh Sattaru (rameshcan) :
review: Approve
Revision history for this message
Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision d679b34356ff6d50c51f25e8a929105a6af81cdb

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/tox.ini b/src/tox.ini
2index 55a6339..84d6f60 100644
3--- a/src/tox.ini
4+++ b/src/tox.ini
5@@ -47,10 +47,14 @@ deps =
6
7 [flake8]
8 ignore =
9- D102 #TODO Missing docstring in public method
10- D103 #TODO Missing docstring in public function
11- W503 #line break before binary operator
12- N818 #exception should be named with an Error suffix
13+ #TODO Missing docstring in public method
14+ D102
15+ #TODO Missing docstring in public function
16+ D103
17+ #line break before binary operator
18+ W503
19+ #exception should be named with an Error suffix
20+ N818
21 exclude =
22 .git,
23 __pycache__,

Subscribers

People subscribed via source and target branches

to all changes: