MongoDB Charm

Merge ~mertkirpici/charm-mongodb:lp/1998094 into charm-mongodb:master

  1. Git
  2. lp:~mertkirpici/charm-mongodb
  3. lp/1998094
  4. Merge into master
Proposed by Mert Kirpici
Status: Merged
Approved by: Erhan Sunar
Approved revision: 4e13774034ebf3ad333c10c2d74b017d49acf476
Merged at revision: 892812a9ec2c6b69bd7020cb99cb38e5cd22272b
Proposed branch: ~mertkirpici/charm-mongodb:lp/1998094
Merge into: charm-mongodb:master
Diff against target: 20 lines (+6/-3)
1 file modified
tox.ini (+6/-3)
Reviewer Review Type Date Requested Status
Erhan Sunar (community) Approve
Ramesh Sattaru (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
BootStack Reviewers Pending
Review via email: mp+433727@code.launchpad.net

Commit message

Close LP #1998094

Description of the change

flake8 6.0.0 does not like it when the inline comments are on the same
line as the ignored rule.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

FAILED: Continuous integration, rev:4e13774034ebf3ad333c10c2d74b017d49acf476
https://jenkins.canonical.com/bootstack/job/lp-charm-mongodb-ci/65/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/1458/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/1715/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-mongodb-ci/65//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

PASSED: Continuous integration, rev:4e13774034ebf3ad333c10c2d74b017d49acf476
https://jenkins.canonical.com/bootstack/job/lp-charm-mongodb-ci/66/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/1476/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/1727/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-mongodb-ci/66//rebuild

review: Approve (continuous-integration)
Revision history for this message
Ramesh Sattaru (rameshcan) :
review: Approve
Revision history for this message
Erhan Sunar (esunar) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 892812a9ec2c6b69bd7020cb99cb38e5cd22272b

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tox.ini b/tox.ini
2index 763a275..050cb1b 100644
3--- a/tox.ini
4+++ b/tox.ini
5@@ -46,9 +46,12 @@ deps =
6
7 [flake8]
8 ignore = E402,E226,W503,W504
9- D101 #TODO Missing docstring in public class
10- D102 #TODO Missing docstring in public method
11- D103 #TODO Missing docstring in public function
12+ #TODO Missing docstring in public class
13+ D101
14+ #TODO Missing docstring in public method
15+ D102
16+ #TODO Missing docstring in public function
17+ D103
18 exclude =
19 .git,
20 __pycache__,

Subscribers

People subscribed via source and target branches

to all changes: