~mertkirpici/charm-logrotated:lp/2017795

Branch merges

Propose for merging

Merged into charm-logrotated:master at revision 55f7ed6f91b9a56f0241e68a4ef5c6cd75fd5492

🤖 prod-jenkaas-bootstack (community): Approve (continuous-integration) on 2023-05-05

Chi Wai CHAN: Approve on 2023-05-05

Erhan Sunar (community): Approve on 2023-05-04

BootStack Reviewers: Pending requested 2023-05-04

Diff: 218 lines (+118/-22)

5 files modified

src/lib/lib_cron.py (+18/-19)
src/tests/functional/test_logrotate.py (+21/-0)
src/tests/unit/conftest.py (+7/-1)
src/tests/unit/requirements.txt (+1/-1)
src/tests/unit/test_logrotate.py (+71/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

7316795... by Mert Kirpici on 2023-05-04

fix: cleanup old cronjobs upon config change

A change in cronjob frequency used to leave the old cronjobs behind,
causing unnecessary execution. This patch is mitigating that behavior
and also adds some tests.

Works-on: 2017795
Signed-off-by: Mert Kırpıcı <email address hidden>

017fd99... by Chi Wai CHAN on 2023-05-05

Add "size" directive for config option "override". This is mutually exclusive with "interval" directive, and if both "size" and "interval" are provided, "size" takes the precedence.

Reviewed-on: https://code.launchpad.net/~raychan96/charm-logrotated/+git/charm-logrotated/+merge/442228
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Erhan Sunar <email address hidden>

e5f3e29... by Chi Wai CHAN on 2023-05-04

Add examples for "size" directive in config.yaml.

cf8e129... by Chi Wai CHAN on 2023-05-03

Add functional test for config option "override".

53663fd... by Chi Wai CHAN on 2023-05-03

Fix deprecated juju_tools.

7d0735f... by Chi Wai CHAN on 2023-04-28

Add "size" directive for config option "override".

4d9208b... by Chi Wai CHAN on 2023-05-02

Allow "override" option to override a single directive (rotate | interval), instead of having to specify both of them.

Reviewed-on: https://code.launchpad.net/~raychan96/charm-logrotated/+git/charm-logrotated/+merge/442076
Reviewed-by: Robert Gildein <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: JamesLin <email address hidden>
Reviewed-by: Erhan Sunar <email address hidden>

03f27b2... by Chi Wai CHAN on 2023-05-02

Prevent get_override_settings(file_path) from raising error when
file_path is not in override option.

5a5ee96... by Chi Wai CHAN on 2023-04-28

Allow "override" option to override a single directive (rotate | interval), instead of having to specify both of them.

ebb62b6... by Martin Kalcok on 2023-04-27

Revert to default value when 'update-cron-daily-schedule' is 'unset'.

Reviewed-on: https://code.launchpad.net/~martin-kalcok/charm-logrotated/+git/charm-logrotated/+merge/441934
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: JamesLin <email address hidden>