~mertkirpici/charm-hw-health:lp/2036300

Branch merges

Propose for merging

Merged into charm-hw-health:master at revision dc253db4e00dadb588b0c667eded65c57d59b768

Robert Gildein: Approve on 2023-10-05

🤖 prod-jenkaas-bootstack (community): Approve (continuous-integration) on 2023-10-05

Nikita Koltsov: Approve on 2023-10-04

Paul Goins: Approve on 2023-09-29

Diff: 164 lines (+85/-13)

4 files modified

charmcraft.yaml (+1/-9)
src/files/ilorest/cron_ilorest.py (+14/-3)
src/tests/functional/test_hwhealth.py (+0/-1)
src/tests/unit/test_cron_ilorest.py (+70/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

61b2bb7... by Mert Kirpici on 2023-10-04

test(ilorest): call public login/logout methods

Works-on: 2036300
Signed-off-by: Mert Kırpıcı <email address hidden>

41e823d... by Mert Kirpici on 2023-10-04

test(ilorest): add unittests for main

Works-on: 2036300
Signed-off-by: Mert Kırpıcı <email address hidden>

f915684... by Mert Kirpici on 2023-10-03

chore: drop bionic support

Signed-off-by: Mert Kırpıcı <email address hidden>

464242f... by Mert Kirpici on 2023-09-27

chore: fix lint issues

pylint does not like type comparisons, advises to use isinstance()
instead.

Signed-off-by: Mert Kırpıcı <email address hidden>

4e30c25... by Mert Kirpici on 2023-09-27

fix(cron_ilorest.py): ilorest login before checks

As discovered by Paul Goins not issuing an "ilorest login" before
calling "ilorest list" sometimes causes an "Error 32 occurred while
exchange chif packet" error when the script is run by cron in the
minimal environment that crond provides.

The exact root cause is still unknown however this patch tries to
mitigate this behavior in light of Paul's discovery.

Works-on: 2036300
Signed-off-by: Mert Kırpıcı <email address hidden>

eb2271b... by Haw Loeung on 2023-07-24

Fix excludes for ilorest

Reviewed-on: https://code.launchpad.net/~hloeung/charm-hw-health/+git/charm-hw-health/+merge/447366
Reviewed-by: Robert Gildein <email address hidden>
Reviewed-by: Barry Price <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Tianqi Xiao <email address hidden>

2bdc7ef... by Haw Loeung on 2023-07-21

Fix excludes for ilorest

21c8e0d... by Ashley James on 2023-07-06

Update metadata to include docs and deprecation notice.

Reviewed-on: https://code.launchpad.net/~dashmage/charm-hw-health/+git/charm-hw-health/+merge/446167
Reviewed-by: Robert Gildein <email address hidden>
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>

4b87eaf... by Ashley James on 2023-07-06

Update metadata.yaml

- Add `docs` key pointing to discourse link.
- Update description to include deprecation notice.

3129597... by Ashley James on 2023-06-30

Add basic smoke test.

- Add clearer comment in charmcraft.yaml for bionic fix.
- Remove xenial support.
- Add basic smoke test for deployment sanity check without attaching resources.

Reviewed-on: https://code.launchpad.net/~dashmage/charm-hw-health/+git/charm-hw-health/+merge/445504
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: JamesLin <email address hidden>
Reviewed-by: Chi Wai CHAN <email address hidden>
Reviewed-by: Ramesh Sattaru <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Sudeep Bhandari <email address hidden>