Merge lp:~menesis/schooltool/flourish into lp:schooltool/flourish

Proposed by Gediminas Paulauskas
Status: Merged
Merged at revision: 2962
Proposed branch: lp:~menesis/schooltool/flourish
Merge into: lp:schooltool/flourish
Diff against target: 148 lines (+56/-6) (has conflicts)
7 files modified
src/schooltool/basicperson/browser/person.py (+8/-4)
src/schooltool/contact/browser/contact.py (+4/-2)
src/schooltool/person/browser/f_password_form.pt (+1/-0)
src/schooltool/person/browser/flourish.zcml (+12/-0)
src/schooltool/person/browser/person.py (+6/-0)
src/schooltool/skin/flourish/resources/flourish.css (+17/-0)
src/schooltool/skin/flourish/resources/page.css (+8/-0)
Text conflict in src/schooltool/person/browser/flourish.zcml
Text conflict in src/schooltool/skin/flourish/resources/flourish.css
To merge this branch: bzr merge lp:~menesis/schooltool/flourish
Reviewer Review Type Date Requested Status
Douglas Cerna Pending
Review via email: mp+66468@code.launchpad.net

Description of the change

Filtered empty person fields, made expanded page wide, added password form.

To post a comment you must log in.
lp:~menesis/schooltool/flourish updated
2958. By Douglas Cerna

Changed ExpandedPage class name to NoSidebarPage. Also conditioned sidebar rendering

2959. By Douglas Cerna

Removed label from contact edit form and styled contact forms errors

2960. By Alan Elkner

various chnages to the reorder.html view

2961. By Alan Elkner

swapped student and teacher columns to match edit views

2962. By Douglas Cerna

Merged Gediminas filter of empty person fields and password form

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/schooltool/basicperson/browser/person.py'
2--- src/schooltool/basicperson/browser/person.py 2011-06-29 15:04:50 +0000
3+++ src/schooltool/basicperson/browser/person.py 2011-06-30 14:43:28 +0000
4@@ -741,8 +741,10 @@
5 rows = []
6 fields = field.Fields(IBasicPerson)
7 for attr in fields:
8- label = fields[attr].field.title
9- rows.append(self.makeRow(label, getattr(self.context, attr)))
10+ value = getattr(self.context, attr)
11+ if value:
12+ label = fields[attr].field.title
13+ rows.append(self.makeRow(label, value))
14 return rows
15
16 @property
17@@ -775,8 +777,10 @@
18 rows = []
19 demographics = IDemographics(self.context)
20 for attr in fields:
21- label = fields[attr].field.title
22- rows.append(self.makeRow(label, demographics[attr]))
23+ value = demographics[attr]
24+ if value:
25+ label = fields[attr].field.title
26+ rows.append(self.makeRow(label, value))
27 return rows
28
29 @property
30
31=== modified file 'src/schooltool/contact/browser/contact.py'
32--- src/schooltool/contact/browser/contact.py 2011-06-29 15:04:50 +0000
33+++ src/schooltool/contact/browser/contact.py 2011-06-30 14:43:28 +0000
34@@ -743,8 +743,10 @@
35 rows = []
36 fields = field.Fields(IAddress, IEmails, IPhones, ILanguages)
37 for attr in fields:
38- label = fields[attr].field.title
39- rows.append(self.makeRow(label, getattr(contact, attr)))
40+ value = getattr(contact, attr)
41+ if value:
42+ label = fields[attr].field.title
43+ rows.append(self.makeRow(label, value))
44 return rows
45
46 def makeRow(self, attr, value):
47
48=== added file 'src/schooltool/person/browser/f_password_form.pt'
49--- src/schooltool/person/browser/f_password_form.pt 1970-01-01 00:00:00 +0000
50+++ src/schooltool/person/browser/f_password_form.pt 2011-06-30 14:43:28 +0000
51@@ -0,0 +1,1 @@
52+<div metal:use-macro="macro:form" />
53
54=== modified file 'src/schooltool/person/browser/flourish.zcml'
55--- src/schooltool/person/browser/flourish.zcml 2011-06-29 15:38:03 +0000
56+++ src/schooltool/person/browser/flourish.zcml 2011-06-30 14:43:28 +0000
57@@ -23,6 +23,7 @@
58 permission="schooltool.view"
59 />
60
61+<<<<<<< TREE
62 <configure package="schooltool.skin.flourish">
63 <flourish:page
64 name="index.html"
65@@ -41,4 +42,15 @@
66
67 <zope:adapter factory=".person.CalendarPublicWidgetLabel" name="label" />
68
69+=======
70+ <flourish:page
71+ name="password_edit.html"
72+ for="schooltool.person.interfaces.IPerson"
73+ class=".person.FlourishPersonPasswordEditView"
74+ content_template="f_password_form.pt"
75+ permission="schooltool.edit"
76+ subtitle="Password"
77+ />
78+
79+>>>>>>> MERGE-SOURCE
80 </configure>
81
82=== modified file 'src/schooltool/person/browser/person.py'
83--- src/schooltool/person/browser/person.py 2011-06-29 15:38:03 +0000
84+++ src/schooltool/person/browser/person.py 2011-06-30 14:43:28 +0000
85@@ -284,6 +284,12 @@
86 self.actions['cancel'].addClass('button-cancel')
87
88
89+class FlourishPersonPasswordEditView(flourish.page.Page, PersonPasswordEditView):
90+
91+ def update(self):
92+ PersonPasswordEditView.update(self)
93+
94+
95 class IPersonInfoManager(IViewletManager):
96 """Provides a viewlet hook for the information on a Person's page."""
97
98
99=== modified file 'src/schooltool/skin/flourish/resources/flourish.css'
100--- src/schooltool/skin/flourish/resources/flourish.css 2011-06-29 15:04:50 +0000
101+++ src/schooltool/skin/flourish/resources/flourish.css 2011-06-30 14:43:28 +0000
102@@ -69,6 +69,8 @@
103
104 pre {
105 overflow: auto;
106+ font-size: 12px;
107+ line-height: 16px;
108 }
109
110 a.modify {
111@@ -277,3 +279,18 @@
112 .header ul.breadcrumbs a {
113 color: #aa0000;
114 }
115+<<<<<<< TREE
116+=======
117+
118+
119+/* XXX: where do we put styles like this? */
120+
121+a.manage-contacts-link {
122+ width: auto;
123+ float: left;
124+ display: block;
125+ line-height: 16px;
126+ font-size: 12px;
127+ margin-top: 8px;
128+}
129+>>>>>>> MERGE-SOURCE
130
131=== modified file 'src/schooltool/skin/flourish/resources/page.css'
132--- src/schooltool/skin/flourish/resources/page.css 2011-06-28 16:13:30 +0000
133+++ src/schooltool/skin/flourish/resources/page.css 2011-06-30 14:43:28 +0000
134@@ -59,6 +59,14 @@
135 padding: 16px 192px 16px 16px;
136 }
137
138+.page > .body > .expand_container {
139+ display: block;
140+ float: none;
141+ width: 912px;
142+ background-color: #f7f7f7;
143+ padding: 16px;
144+}
145+
146 /* Refine */
147
148 .page > .body > .refine > .content {

Subscribers

People subscribed via source and target branches