Timer Applet

Merge lp:~mehra-vinayak/timer-applet/remove-unused-imports into lp:timer-applet

  1. remove-unused-imports
  2. Merge into timer-applet
Proposed by Kenny Meyer
Status: Work in progress
Proposed branch: lp:~mehra-vinayak/timer-applet/remove-unused-imports
Merge into: lp:timer-applet
Diff against target: 36 lines (+1/-3)
3 files modified
timer-applet/po/LINGUAS (+0/-1)
timer-applet/src/timerapplet/controllers/TimerApplet.py (+0/-1)
timer-applet/src/timerapplet/core/PresetsStore.py (+1/-1)
To merge this branch: bzr merge lp:~mehra-vinayak/timer-applet/remove-unused-imports
Reviewer Review Type Date Requested Status
Kenny Meyer Needs Fixing
Review via email: mp+44994@code.launchpad.net

Commit message

Remove unused imports from source files

To post a comment you must log in.
Revision history for this message
Kenny Meyer (knny-myer) wrote :

It seems like you haven't committed your changes. Please do that.

review: Needs Fixing
Reply
Revision history for this message
vinayak (mehra-vinayak) wrote :

> It seems like you haven't committed your changes. Please do that.

Committed the changes .

Reply
lp:~mehra-vinayak/timer-applet/remove-unused-imports updated
348. By vinayak

"Committing the changes in the branch for review"

Revision history for this message
vinayak (mehra-vinayak) wrote :

Hi Kenny ,

I have done the changes ,commiteed them and pushed the changes to branch .Please review

Regards

Reply
Revision history for this message
Kenny Meyer (knny-myer) wrote :

Sorry, for the long delay in response.

You weren't supposed to modify timer-applet/po/LINGUAS. Please make another commit to revert removing `es'. That's needed so translation will be compiled later on.

Otherwise it looks fine! :)

review: Needs Fixing
Reply

Unmerged revisions

348. By vinayak

"Committing the changes in the branch for review"

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'timer-applet/po/LINGUAS'
2--- timer-applet/po/LINGUAS 2008-12-01 16:10:15 +0000
3+++ timer-applet/po/LINGUAS 2011-01-02 11:08:10 +0000
4@@ -7,7 +7,6 @@
5 en_AU
6 en_GB
7 eo
8-es
9 eu
10 fa
11 fi
12
13=== modified file 'timer-applet/src/timerapplet/controllers/TimerApplet.py'
14--- timer-applet/src/timerapplet/controllers/TimerApplet.py 2010-11-28 10:15:32 +0000
15+++ timer-applet/src/timerapplet/controllers/TimerApplet.py 2011-01-02 11:08:10 +0000
16@@ -22,7 +22,6 @@
17 import gst
18 import gtk
19 import gtk.glade as glade
20-import gtk.gdk as gdk
21 import subprocess
22 import shlex
23 import threading
24
25=== modified file 'timer-applet/src/timerapplet/core/PresetsStore.py'
26--- timer-applet/src/timerapplet/core/PresetsStore.py 2010-09-15 12:29:45 +0000
27+++ timer-applet/src/timerapplet/core/PresetsStore.py 2011-01-02 11:08:10 +0000
28@@ -24,7 +24,7 @@
29 from os import path
30 import gobject
31 import gtk
32-import timerapplet.utils as utils
33+
34
35 from timerapplet.utils import (serialize_bool,
36 deserialize_bool,

Subscribers

People subscribed via source and target branches

to all changes: