Merge lp:~mefrio-g/slingshot/fix-991888 into lp:~elementary-pantheon/slingshot/trunk

Proposed by Mario Guerriero
Status: Rejected
Rejected by: Victor Martinez
Proposed branch: lp:~mefrio-g/slingshot/fix-991888
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 42 lines (+7/-4)
2 files modified
src/Widgets/CategoryView.vala (+1/-1)
src/Widgets/Sidebar.vala (+6/-3)
To merge this branch: bzr merge lp:~mefrio-g/slingshot/fix-991888
Reviewer Review Type Date Requested Status
Cody Garver (community) Disapprove
Review via email: mp+104768@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

This patch is no longer necessary. Thanks anyway, Mario.

review: Disapprove

Unmerged revisions

179. By Mario Guerriero

fixed bug #991888

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/CategoryView.vala'
2--- src/Widgets/CategoryView.vala 2012-04-25 09:06:16 +0000
3+++ src/Widgets/CategoryView.vala 2012-05-04 16:05:22 +0000
4@@ -149,7 +149,7 @@
5 category_switcher.selection_changed.connect ((name, nth) => {
6
7 string category = category_ids.get (nth);
8-
9+
10 if (name == MOST_USED_APPS)
11 category = name;
12
13
14=== modified file 'src/Widgets/Sidebar.vala'
15--- src/Widgets/Sidebar.vala 2012-04-25 09:06:16 +0000
16+++ src/Widgets/Sidebar.vala 2012-05-04 16:05:22 +0000
17@@ -27,7 +27,8 @@
18 private TreeIter bookmarks_iter;
19 private TreeIter category_iter;
20 private TreeIter entry_iter;
21-
22+ private TreeIter? previous_iter = null;
23+
24 private int cat_size {
25 get {
26 return store.iter_n_children (category_iter);
27@@ -122,11 +123,13 @@
28 * If it is, select the previous selected entry.
29 */
30 if (sel_iter == category_iter || sel_iter == bookmarks_iter) {
31- selected = _selected;
32+ get_selection ().unselect_iter (sel_iter);
33+ get_selection ().select_iter (previous_iter);
34 } else {
35 _selected = nth;
36 selection_changed (name, nth);
37- }
38+ previous_iter = sel_iter;
39+ }
40 }
41
42 }

Subscribers

People subscribed via source and target branches