Code review comment for lp:~mefrio-g/pantheon-notify/fix-986822

Revision history for this message
Victor Martinez (victored) wrote :

It would be better if you escaped the text before setting the markup. For instance:

name = Markup.escape (name, -1);
body = Markup.escape (body -1);
text.set_markup ("<span font='10' weight='bold'>" + name + "</span>\n<span font='9'>" + body + "</span>");

review: Needs Fixing

« Back to merge proposal