Merge lp:~mefrio-g/granite/dynamicnotebook-add-right into lp:~elementary-pantheon/granite/granite

[Mario Guerriero]

I've moved the DynamicNotebook's add button to the right, as Sergey suggested in the mailing list

[Sergey "Shnatsel" Davidoff (shnatsel)]

Wait wait wait, I suggested opening new tabs to the left! https://blueprints.launchpad.net/granite/+spec/tabbar explicitly states that the new tab button should be on the left in LTR systems. However, it does not describe where new tabs should be opened.

[Sergey "Shnatsel" Davidoff (shnatsel)]

review: Disapprove

[Harvey Cabaguio (harveycabaguio)]

I think the intended behaviour is that the new tab button goes on the left because typically "new object" buttons on the toolbar are typically on the left. And new tabs would appear on the left as well because most recent to less recent is an order that makes sense to us.

Unmerged revisions

316. By Mario Guerriero on 2012-07-23

add button in DynamicNotebook is on the right

=== modified file 'lib/Widgets/DynamicNotebook.vala'
--- lib/Widgets/DynamicNotebook.vala	2012-07-22 16:11:15 +0000
+++ lib/Widgets/DynamicNotebook.vala	2012-07-23 13:39:20 +0000
@@ -291,7 +291,7 @@
             add.margin_left = 6;
             add.relief = Gtk.ReliefStyle.NONE;
             add.tooltip_text = _("New tab");
-            this.notebook.set_action_widget (add, Gtk.PackType.START);
+            this.notebook.set_action_widget (add, Gtk.PackType.END);
             add.show_all ();
             add.get_style_context ().add_provider (button_fix, Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION);