Granite

Merge lp:~mefrio-g/granite/1198456 into lp:~elementary-pantheon/granite/granite

  1. 1198456
  2. Merge into granite
Proposed by Mario Guerriero
Status: Rejected
Rejected by: David Gomes
Proposed branch: lp:~mefrio-g/granite/1198456
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 18 lines (+0/-2)
1 file modified
lib/Widgets/DynamicNotebook.vala (+0/-2)
To merge this branch: bzr merge lp:~mefrio-g/granite/1198456
Reviewer Review Type Date Requested Status
Cody Garver (community) Needs Fixing
Review via email: mp+173308@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

This breaks functionality in pantheon-files that restores closed tabs.

review: Needs Fixing
Revision history for this message
Mario Guerriero (mefrio-g) wrote :

If gli merge this branch Files will need a one or two lines commit to restore the compatibility.

Unmerged revisions

596. By Mario Guerriero

fix for the previous commit

595. By Mario Guerriero

fixed bug #1198456

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/DynamicNotebook.vala'
2--- lib/Widgets/DynamicNotebook.vala 2013-07-02 14:40:18 +0000
3+++ lib/Widgets/DynamicNotebook.vala 2013-07-06 13:15:31 +0000
4@@ -491,7 +491,6 @@
5 if (!allow_restoring)
6 return;
7 restore_button.sensitive = !closed_tabs.empty;
8- insert_tab (tab, -1);
9 this.tab_restored (tab);
10 });
11
12@@ -679,7 +678,6 @@
13 var tab = closed_tabs.pop ();
14 restore_button.sensitive = !closed_tabs.empty;
15 restore_tab_m.sensitive = !closed_tabs.empty;
16- insert_tab (tab, -1);
17 this.tab_restored (tab);
18 }
19

Subscribers

People subscribed via source and target branches