Merge lp:~meese/slingshot/fix-1084886 into lp:~elementary-pantheon/slingshot/trunk
Proposed by
meese
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Cody Garver | ||||
Proposed branch: | lp:~meese/slingshot/fix-1084886 | ||||
Merge into: | lp:~elementary-pantheon/slingshot/trunk | ||||
Diff against target: |
20 lines (+9/-1) 1 file modified
src/SlingshotView.vala (+9/-1) |
||||
To merge this branch: | bzr merge lp:~meese/slingshot/fix-1084886 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cody Garver (community) | Disapprove | ||
Review via email: mp+233187@code.launchpad.net |
Commit message
makes right click on search entry pastes clipboard contents
Description of the change
Partially fixes 1084886 by making right click on the top search entry paste clipboard contents. Copy isn't really necessary for a search entry as a user is unlikely to want to copy information they just put in themselves. Also popup menus do not play nicely with slingshots window in its current form.
To post a comment you must log in.
You shouldn't be checking if event.button is 3. I believe there is a
cleaner approach but I'm on my phone now. Will look for it later.
On Sep 3, 2014 10:40 AM, "meese" <email address hidden> wrote:
> meese has proposed merging lp:~madelynn-r-may/slingshot/fix-1084886 into pantheon) /bugs.launchpad .net/slingshot/ +bug/1084886 /code.launchpad .net/~madelynn- r-may/slingshot /fix-1084886/ +merge/ 233187 /code.launchpad .net/~madelynn- r-may/slingshot /fix-1084886/ +merge/ 233187 iew.vala' ew.vala 2014-08-31 21:38:07 +0000 ew.vala 2014-09-03 09:39:35 +0000 entry.placehold er_text = _("Search Apps…"); entry.width_ request = 250; entry.button_ press_event. connect ((e) => {return entry.button_ press_event. connect ((event) => { CLIPBOARD) ; entry.text = text; settings. show_category_ filter) {
> lp:slingshot.
>
> Commit message:
> makes right click on search entry pastes clipboard contents
>
> Requested reviews:
> elementary Pantheon team (elementary-
> Related bugs:
> Bug #1084886 in Slingshot: "No right click menu in search [$15]"
> https:/
>
> For more details, see:
>
> https:/
>
> Partially fixes 1084886 by making right click on the top search entry
> paste clipboard contents. Copy isn't really necessary for a search entry as
> a user is unlikely to want to copy information they just put in themselves.
> Also popup menus do not play nicely with slingshots window in its current
> form.
> --
>
> https:/
> Your team elementary Pantheon team is requested to review the proposed
> merge of lp:~madelynn-r-may/slingshot/fix-1084886 into lp:slingshot.
>
> === modified file 'src/SlingshotV
> --- src/SlingshotVi
> +++ src/SlingshotVi
> @@ -164,7 +164,15 @@
> dummy_search_entry = new Gtk.SearchEntry ();
> dummy_search_
> dummy_search_
> - dummy_search_
> e.button == 3;});
> + dummy_search_
> + if (event.button == 3) {
> + var cb = Gtk.Clipboard.@get
> (Gdk.SELECTION_
> + var text = cb.wait_for_text ();
> + dummy_search_
> + return true;
> + }
> + return false;
> + });
>
> if (Slingshot.
> top.attach (view_selector, 0, 0, 1, 1);
>
>
>