Photos

Merge lp:~meese/pantheon-photos/remove-external into lp:~pantheon-photos/pantheon-photos/trunk

  1. remove-external
  2. Merge into trunk
Proposed by meese
Status: Rejected
Rejected by: Cody Garver
Proposed branch: lp:~meese/pantheon-photos/remove-external
Merge into: lp:~pantheon-photos/pantheon-photos/trunk
Diff against target: 11 lines (+0/-1)
1 file modified
src/Dialogs.vala (+0/-1)
To merge this branch: bzr merge lp:~meese/pantheon-photos/remove-external
Reviewer Review Type Date Requested Status
Cody Garver (community) Disapprove
Review via email: mp+231453@code.launchpad.net

Commit message

removes external tab from preferences

Description of the change

completely removes external tab from preferences that should have been removed by branch fix-1321029. No longer needed as open with external is in the context menu now

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

There's a competing, more complete branch lp:~ffabio-96-x/pantheon-photos/fix-1357862

review: Disapprove
Revision history for this message
meese (meese) wrote :

oops didn't see, rushed to make a fix when I noticed it as it was my fault..

Unmerged revisions

2582. By meese

remove external tab from preferences

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Dialogs.vala'
2--- src/Dialogs.vala 2014-08-14 02:01:42 +0000
3+++ src/Dialogs.vala 2014-08-19 20:56:21 +0000
4@@ -2235,7 +2235,6 @@
5 Gtk.Stack container = new Gtk.Stack ();
6 container.expand = true;
7 container.add_titled (builder.get_object ("preferences_library") as Gtk.Box, "library", _ ("Library"));
8- container.add_titled (builder.get_object ("preferences_external") as Gtk.Box, "external", _ ("External"));
9 container.add_titled (builder.get_object ("preferences_plugins") as Gtk.Box, "plugins", _ ("Plugins"));
10
11 Gtk.StackSwitcher switcher = new Gtk.StackSwitcher ();

Subscribers

People subscribed via source and target branches

to all changes: