Merge ~medicalwei/plainbox-provider-checkbox:fixed-screen-orientation-on-laptops into plainbox-provider-checkbox:master

[Yao Wei]

[Kai-Chuan Hsieh (kchsieh)]

I think it is better to use template-filter to perform it on device with accel_3d sensor only.

review: Needs Fixing

[Yao Wei (medicalwei)]

The script "fixed_screen_orientation.sh" runs as follows:

ubuntu@machine:~$ ./fixed_screen_orientation.sh
E: DEVTYPE=iio_device
E: DEVTYPE=iio_device
E: DEVTYPE=iio_device
E: DEVTYPE=iio_device
Screen orientation check PASSED: Accelerometer is not enabled

[Kai-Chuan Hsieh (kchsieh)]

Please also paste the failed output to here or paste bin. The rest looks good to me.

review: Approve

[Yao Wei (medicalwei)]

This is the failed result from the machine with known issue. I cannot run the test job since the machine I have reports itself as a convertible while it is actually not, and this issue is reported to the manufacturer.

ubuntu@machine:~$ ./fixed_screen_orientation.sh

Screen orientation check FAILED:
this device has an accelerometer that needs to be disabled.
===
udevadm info /sys/bus/iio/devices/iio*
P: /devices/pci0000:00/0000:00:12.0/{33AECD58-B679-4E54-9BD9-A04D34F0C226}/001F:8087:0AC2.0004/HID-SENSOR-INT-020b/iio:device0
N: iio:device0
L: 0
E: DEVPATH=/devices/pci0000:00/0000:00:12.0/{33AECD58-B679-4E54-9BD9-A04D34F0C226}/001F:8087:0AC2.0004/HID-SENSOR-INT-020b/iio:device0
E: DEVNAME=/dev/iio:device0
E: DEVTYPE=iio_device
E: MAJOR=509
E: MINOR=0
E: SUBSYSTEM=iio

P: /devices/pci0000:00/0000:00:12.0/{33AECD58-B679-4E54-9BD9-A04D34F0C226}/001F:8087:0AC2.0002/HID-SENSOR-200041.7.auto/iio:device1
N: iio:device1
L: 0
E: DEVPATH=/devices/pci0000:00/0000:00:12.0/{33AECD58-B679-4E54-9BD9-A04D34F0C226}/001F:8087:0AC2.0002/HID-SENSOR-200041.7.auto/iio:device1
E: DEVNAME=/dev/iio:device1
E: DEVTYPE=iio_device
E: MAJOR=509
E: MINOR=1
E: SUBSYSTEM=iio
E: USEC_INITIALIZED=9216800
E: IIO_SENSOR_PROXY_TYPE=iio-poll-als iio-buffer-als
E: SYSTEMD_WANTS=iio-sensor-proxy.service
E: TAGS=:systemd:

P: /devices/pci0000:00/0000:00:12.0/{33AECD58-B679-4E54-9BD9-A04D34F0C226}/001F:8087:0AC2.0005/HID-SENSOR-200076.28.auto/iio:device2
N: iio:device2
L: 0
E: DEVPATH=/devices/pci0000:00/0000:00:12.0/{33AECD58-B679-4E54-9BD9-A04D34F0C226}/001F:8087:0AC2.0005/HID-SENSOR-200076.28.auto/iio:device2
E: DEVNAME=/dev/iio:device2
E: DEVTYPE=iio_device
E: MAJOR=509
E: MINOR=2
E: SUBSYSTEM=iio

P: /devices/pci0000:00/0000:00:12.0/{33AECD58-B679-4E54-9BD9-A04D34F0C226}/001F:8087:0AC2.0004/HID-SENSOR-200073.26.auto/iio:device3
N: iio:device3
L: 0
E: DEVPATH=/devices/pci0000:00/0000:00:12.0/{33AECD58-B679-4E54-9BD9-A04D34F0C226}/001F:8087:0AC2.0004/HID-SENSOR-200073.26.auto/iio:device3
E: DEVNAME=/dev/iio:device3
E: DEVTYPE=iio_device
E: MAJOR=509
E: MINOR=3
E: SUBSYSTEM=iio
E: USEC_INITIALIZED=9236113
E: IIO_SENSOR_PROXY_TYPE=iio-poll-accel iio-buffer-accel
E: SYSTEMD_WANTS=iio-sensor-proxy.service
E: TAGS=:systemd:

[Maciej Kisielewski (kissiel)]

LGTM, +1.

review: Approve

diff --git a/bin/fixed_screen_orientation.sh b/bin/fixed_screen_orientation.sh
new file mode 100755
index 0000000..5fbe162
--- /dev/null
+++ b/bin/fixed_screen_orientation.sh
@@ -0,0 +1,22 @@
+#!/bin/sh
+if ! (udevadm info --export-db | grep -q iio_device); then
+   echo "Screen orientation check PASSED:"
+   echo "no iio_device found in this device, therefore rotation should not happen."
+   exit 0
+fi
+
+if dbus-send --system --print-reply --dest=net.hadess.SensorProxy \
+  /net/hadess/SensorProxy \
+  org.freedesktop.DBus.Properties.Get string:net.hadess.SensorProxy string:HasAccelerometer |
+  grep -q "boolean true"; then
+  echo "Screen orientation check FAILED:"
+  echo "this device has an accelerometer that needs to be disabled."
+  echo "==="
+  # list IIO devices for reference
+  echo "udevadm info /sys/bus/iio/devices/iio*"
+  udevadm info /sys/bus/iio/devices/iio*
+  exit 1
+fi
+
+echo "Screen orientation check PASSED:"
+echo "Accelerometer is not enabled."
diff --git a/units/input/jobs.pxu b/units/input/jobs.pxu
index 5f5cde0..7ae0667 100644
--- a/units/input/jobs.pxu
+++ b/units/input/jobs.pxu
@@ -75,3 +75,19 @@ _steps:
     4. Double-click the left button with your {product}.
 _verification:
     Did these buttons work as expected?
+
+unit: template
+template-resource: dmi
+template-filter: dmi.category == 'CHASSIS' and dmi.product not in ('Tablet', 'Convertible', 'Detachable')
+plugin: shell
+category_id: com.canonical.plainbox::input
+estimated_duration: 2
+id: input/fixed_screen_orientation_on_{product}_{__index__}
+user: root
+requires:
+ executable.name == 'udevadm'
+ executable.name == 'dbus-send'
+command: fixed_screen_orientation.sh
+_summary: Check whether screen orientation is fixed on {product}
+_purpose:
+    This tests whether the display orientation of {product} is fixed, and cannot be altered by tilting {product}.
diff --git a/units/input/test-plan.pxu b/units/input/test-plan.pxu
index ef9cf75..1c87d1f 100644
--- a/units/input/test-plan.pxu
+++ b/units/input/test-plan.pxu
@@ -23,7 +23,9 @@ _name: Input tests (Automated)
 _description:
  Input tests (Automated)
 include:
-
+ input/fixed_screen_orientation_on_.*       certification-status=non-blocker
+bootstrap_include:
+ dmi
 
 id: after-suspend-input-cert-full
 unit: test plan