Merge ~medicalwei/plainbox-provider-checkbox:systemd-analyze-wait-for-boot into plainbox-provider-checkbox:master

[Yao Wei]

This fixes LP: #1933901, by waiting for systemd to complete boot before running systemd-analyze.

Our tools might run checkbox tests too early, that when running systemd-analyze, systemd has not complete booting. Therefore we need to wait for the boot to complete before running systemd-analyze.

[jeremyszu (os369510)]

How if system meets this issue?
https://bugs.launchpad.net/plainbox-provider-checkbox/+bug/1910516

review: Needs Information

[Yao Wei (medicalwei)]

> How if system meets this issue?
> https://bugs.launchpad.net/plainbox-provider-checkbox/+bug/1910516

With `systemctl is-systemd-running`, the result may return "degraded" and exit. We just wait for the startup to finish and disregard the result.

[jeremyszu (os369510)]

@Wei,

thanks, LGTM.

Let's waiting for p-p-c maintainers' review.

review: Approve

[Jonathan Cave (jocave)]

Agree that the above needs to be handled and also some kind of general timeout to avoid blocking test runs completely.

review: Needs Fixing

[Yao Wei (medicalwei)]

> Agree that the above needs to be handled and also some kind of general timeout
> to avoid blocking test runs completely.

Added a 60s general timeout. systemd-analyze runs after finishing bootup (either successfully "running" or with error "degraded"), or timeout occurs.

[Rex Tsai (chihchun)]

＠jocave why don't we handle the general timeout from checkbox framework? There are many reason that block a test job to finish (eg, blocked by IO or driver).

I feel like checkbox should have a field to assign timeout, and let checkbox kill the job after timeout. but not handle the timeout in the implementation of the job

[Jonathan Cave (jocave)]

@Rex it's do-able of course, but unlikely to happen as quickly as modifying the job

[Jonathan Cave (jocave)]

LGTM

review: Approve

diff --git a/units/info/jobs.pxu b/units/info/jobs.pxu
index d2ed96b..12d7ab1 100644
--- a/units/info/jobs.pxu
+++ b/units/info/jobs.pxu
@@ -454,7 +454,11 @@ category_id: com.canonical.plainbox::info
 id: info/systemd-analyze
 estimated_duration: 0.2
 _summary: System boot-up performance statistics
-command: systemd-analyze
+command:
+ # Wait for boot to complete
+ # https://github.com/systemd/systemd/pull/9796
+ timeout 60 systemctl is-system-running --wait > /dev/null
+ systemd-analyze
 
 id: lstopo_verbose_attachment
 plugin: attachment