Merge ~medicalwei/debian-cd/+git/ubuntu:oem-mantic into ~ubuntu-cdimage/debian-cd/+git/ubuntu:main

Proposed by Yao Wei
Status: Needs review
Proposed branch: ~medicalwei/debian-cd/+git/ubuntu:oem-mantic
Merge into: ~ubuntu-cdimage/debian-cd/+git/ubuntu:main
Diff against target: 37 lines (+7/-1)
2 files modified
tools/boot/mantic/boot-amd64 (+3/-0)
tools/boot/mantic/common.sh (+4/-1)
Reviewer Review Type Date Requested Status
Steve Langasek Needs Fixing
Yao Wei (community) Abstain
Review via email: mp+446853@code.launchpad.net

Commit message

add ubuntu-oem project for kernel params and initrd

To post a comment you must log in.
Revision history for this message
Yao Wei (medicalwei) wrote :

I am going to disapprove this proposal myself since mantic does not have OEM kernel. We should push this diff on 24.04.

review: Disapprove
Revision history for this message
Steve Langasek (vorlon) wrote :

I think it's fine for us to land such changes in an interim release rather than waiting for the 24.04 cycle to open. In principle this is useful for CI against trunk. (Even if there are no plans for this to happen right now.)

Revision history for this message
Steve Langasek (vorlon) :
review: Needs Fixing
Revision history for this message
Yao Wei (medicalwei) :
review: Abstain
Revision history for this message
Yao Wei (medicalwei) wrote :

I updated it so it takes DEBVERSION and see whether there's LTS in the end of the version name to assume that oem kernel is used. Also, making ubuntu and ubuntu-oem use the same kernel command parameters.

Revision history for this message
Steve Langasek (vorlon) wrote :

This unfortunately should be retargeted to the noble directory now, as tools/boot/mantic is no longer used for any image builds.

review: Needs Fixing

Unmerged commits

e156deb... by Yao Wei

add ubuntu-oem project for kernel params and initrd

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tools/boot/mantic/boot-amd64 b/tools/boot/mantic/boot-amd64
2index 416215f..5cb766e 100755
3--- a/tools/boot/mantic/boot-amd64
4+++ b/tools/boot/mantic/boot-amd64
5@@ -20,6 +20,9 @@ cd $CDDIR/..
6 FLAVOUR=generic
7 if [ "$PROJECT" = "ubuntustudio" ]; then
8 FLAVOUR=lowlatency
9+elif [ "$PROJECT" = "ubuntu-oem" ] && [[ "$DEBVERSION" =~ LTS$ ]]; then
10+ # If it is an LTS version, assume that we have an OEM kernel for it.
11+ FLAVOUR=oem
12 fi
13
14 # rename kernel+initrd
15diff --git a/tools/boot/mantic/common.sh b/tools/boot/mantic/common.sh
16index ee59069..5db9fd0 100644
17--- a/tools/boot/mantic/common.sh
18+++ b/tools/boot/mantic/common.sh
19@@ -1,7 +1,7 @@
20 # encode the right CD kernel parameteres, for every project
21 default_kernel_params() {
22 case $PROJECT in
23- ubuntu)
24+ ubuntu|ubuntu-oem)
25 if [ "$SUBPROJECT" = "legacy" ]; then
26 KERNEL_PARAMS="${KERNEL_PARAMS:+$KERNEL_PARAMS }file=/cdrom/preseed/ubuntu.seed maybe-ubiquity quiet splash --- "
27 elif [ "$SUBPROJECT" = "canary" ]; then
28@@ -13,6 +13,9 @@ default_kernel_params() {
29 # an overlay and boot from.
30 KERNEL_PARAMS="${KERNEL_PARAMS:+$KERNEL_PARAMS }layerfs-path=minimal.standard.live.squashfs --- quiet splash"
31 fi
32+ if [ "$PROJECT" = "ubuntu-oem" ]; then
33+ KERNEL_PARAMS+=" nopersistent"
34+ fi
35 ;;
36 ubuntukylin)
37 KERNEL_PARAMS="${KERNEL_PARAMS:+$KERNEL_PARAMS }file=/cdrom/preseed/ubuntu.seed locale=zh_CN keyboard-configuration/layoutcode?=cn maybe-ubiquity quiet splash --- "

Subscribers

People subscribed via source and target branches